1080250 - Tweak the display of Win64 builds & tests to match the TBPL changes

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

Once bug 1080249 is fixed for TBPL, we'll need the same changes for Treeherder.

Comment 1

[Matt]

Why can't I vote for this bug?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

What's there to vote on here? This is about changing the UI of our dashboards for monitoring build and test results. It has nothing to do with what builds and tests are being scheduled, though.

Comment 3

[Matt]

I was just confused as I have had the option of clicking "vote" next to the importance field in every other bug that I've ever looked at. This is nice because you get emails with updates without having to comment or add yourself to the cc list.

Why do I care about this particular bug? Because it's blocking 880004, which I'm interested in.

I guess the question is more about Bugzilla itself and maybe I should file a bug, but I thought if someone knew why this bug was special then some time could be saved.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I believe that voting is enabled on a per-component basis. Sorry, you'll have to live with CCing yourself to this one if you want to follow along.

Comment 5

[Matt]

That makes sense. I'm on it now so no big deal. Thanks for explaining.

Comment 7

[Ed Morley [:emorley]]

TBPL's initial change:
https://hg.mozilla.org/webtools/tbpl/rev/547a7de112ac

diff --git a/js/Config.js b/js/Config.js
...
     "windows8-32": "Windows 8",
+    "windows8-64": "Windows 8 x64",
     "windows2012-64": "Windows 2012 x64",

diff --git a/js/Data.js b/js/Data.js
...
         // Windows x64 builds are created on Win Server 2k8, but for the sake
-        // of consistency, we display them on the same row as the Win2012 tests
-        /WINNT 6\.1 x(?:86-)?64|win64/i.test(name) ? "windows2012-64" :
+        // of consistency, we display them on the same row as the Win8 x64 tests
+        /WINNT 6\.1 x(?:86-)?64|win8_64/i.test(name) ? "windows8-64" :
+        /win64_vm/i.test(name) ? "windows2012-64" :
         /WINNT 6\.1|win7|Windows 7 32-bit/i.test(name) ? "windows7-32" :
         /WINNT 6\.2|win8/i.test(name) ? "windows8-32" :

Plus:
(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from bug 1085548 comment #0)
> From win8_64 to Windows 8 64-bit, could you please update treeherder?
> 
> -PLATFORMS['win64']['win8_64'] = {'name': 'win8_64'}
> +PLATFORMS['win64']['win8_64'] = {'name': 'Windows 8 64-bit'}

Comment 8

[Ed Morley [:emorley]]

Attachment: UI part

Comment 9

[Ed Morley [:emorley]]

Attachment: Service part

Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/547a7de112ac
plus the followup bug 1085549.

(This is rebased on PR #256 to avoid future conflicts, so please look at the commit diff directly [1] or wait until that PR is merged to master, so the PR is cleaner)

[1] https://github.com/mozilla/treeherder-service/commit/49fd42996de5583475054b715515124f2b6adc4e

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/194fc734929d268cb70f32e79ee07a2c4e2c5dc3
Bug 1080250 - Add support for Windows 8 x64

Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/547a7de112ac
plus the followup bug 1085549.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/c658e626fff97a6ef95212f30609b6e514636cd7
Bug 1080250 - Add support for Windows 8 x64

Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/547a7de112ac

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2e2c4841a62bf79a731d2b88a29381c3a661f8c3
Bug 1080250 - Add support for Windows 8 x64

Treeherder equivalent of:
https://hg.mozilla.org/webtools/tbpl/rev/547a7de112ac