Closed
Bug 1080277
Opened 10 years ago
Closed 10 years ago
Braces are missing in GfxInfo::GetFeatureStatusImpl
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
1.45 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/GfxInfoX11.cpp#344 > if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1)) > *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION; > aSuggestedDriverVersion.AssignLiteral("Mesa 8.1"); I guess this should be braced like following, otherwise AssignLiteral will be called regardless of the condition. > if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1)) { > *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION; > aSuggestedDriverVersion.AssignLiteral("Mesa 8.1"); > }
Assignee | ||
Comment 1•10 years ago
|
||
Guessing from indentation, adding braces should be correct fix. If it's just a wrong indentation, please tell me :) Then, I'm not sure how to test that code path (maybe it requires specific hardware or driver). Try run on linux64 is enough?
Attachment #8502148 -
Flags: review?(jgilbert)
Comment 2•10 years ago
|
||
Comment on attachment 8502148 [details] [diff] [review] Add missing braces in GfxInfo::GetFeatureStatusImpl. Review of attachment 8502148 [details] [diff] [review]: ----------------------------------------------------------------- Wow, yep. Thanks for finding this.
Attachment #8502148 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b4b998bfc851
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0daef5a46f40
Assignee: nobody → arai_a
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0daef5a46f40
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•