Closed Bug 1080277 Opened 5 years ago Closed 5 years ago

Braces are missing in GfxInfo::GetFeatureStatusImpl

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/GfxInfoX11.cpp#344
>          if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1))
>            *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>            aSuggestedDriverVersion.AssignLiteral("Mesa 8.1");

I guess this should be braced like following, otherwise AssignLiteral will be called regardless of the condition.

>          if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1)) {
>            *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>            aSuggestedDriverVersion.AssignLiteral("Mesa 8.1");
>          }
Blocks: 779580
Guessing from indentation, adding braces should be correct fix.
If it's just a wrong indentation, please tell me :)

Then, I'm not sure how to test that code path (maybe it requires specific hardware or driver).
Try run on linux64 is enough?
Attachment #8502148 - Flags: review?(jgilbert)
Comment on attachment 8502148 [details] [diff] [review]
Add missing braces in GfxInfo::GetFeatureStatusImpl.

Review of attachment 8502148 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, yep. Thanks for finding this.
Attachment #8502148 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/0daef5a46f40
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.