1080277 - Braces are missing in GfxInfo::GetFeatureStatusImpl

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Tooru Fujisawa [:arai]]

http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/GfxInfoX11.cpp#344
>          if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1))
>            *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>            aSuggestedDriverVersion.AssignLiteral("Mesa 8.1");

I guess this should be braced like following, otherwise AssignLiteral will be called regardless of the condition.

>          if (mIsIntel && version(mMajorVersion, mMinorVersion) < version(8,1)) {
>            *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>            aSuggestedDriverVersion.AssignLiteral("Mesa 8.1");
>          }

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Add missing braces in GfxInfo::GetFeatureStatusImpl.

Guessing from indentation, adding braces should be correct fix.
If it's just a wrong indentation, please tell me :)

Then, I'm not sure how to test that code path (maybe it requires specific hardware or driver).
Try run on linux64 is enough?

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8502148 [details] [diff] [review]
Add missing braces in GfxInfo::GetFeatureStatusImpl.

Review of attachment 8502148 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, yep. Thanks for finding this.

Comment 3

[Tooru Fujisawa [:arai]]

Green on try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b4b998bfc851

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0daef5a46f40

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0daef5a46f40