Blacklist WebGL MSAA on Intel driver on Mesa 8.1, as it was lying about GL_MAX_SAMPLES

RESOLVED FIXED in mozilla17

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: webgl-conformance)

Attachments

(1 attachment, 1 obsolete attachment)

As discussed on the mesa-dev list, the Intel Mesa driver (as of Mesa 8.0) wrongly returns GL_MAX_SAMPLES>0 even though the correct value is 0 (does not support msaa FBOs).

That's causing a test failure in https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/conformance/context/context-attributes-alpha-depth-stencil-antialias.html which is actually the very last 1.0.1 test failure.

Setting webgl.msaa-level=0 does now give a full pass, and as we already have a full pass on NVIDIA 302.17, it's worth doing a little workaround to get that second full pass we need to claim conformance on Linux.

So let's assume that Intel Mesa never supports msaa FBOs, until further notice. I asked mesa devs if it's already fixed in trunk; if it is, we'll do a version check instead.
(Assignee)

Updated

5 years ago
Summary: Assume that the Intel Mesa driver lies about GL_MAX_SAMPLES, assume 0 → Blacklist WebGL MSAA on Intel Mesa driver until it stops lying about GL_MAX_SAMPLES
(Assignee)

Comment 1

5 years ago
Created attachment 648034 [details] [diff] [review]
block msaa on Intel
Attachment #648034 - Flags: review?(jgilbert)
(Assignee)

Comment 2

5 years ago
Created attachment 648037 [details] [diff] [review]
block msaa on Intel on Mesa < 8.1
Attachment #648034 - Attachment is obsolete: true
Attachment #648034 - Flags: review?(jgilbert)
Attachment #648037 - Flags: review?(jgilbert)
(Assignee)

Comment 3

5 years ago
Ken from the mesa-dev list confirmed that this is fixed in versions >= 8.1.0.
Summary: Blacklist WebGL MSAA on Intel Mesa driver until it stops lying about GL_MAX_SAMPLES → Blacklist WebGL MSAA on Intel driver on Mesa 8.1, as it was lying about GL_MAX_SAMPLES
Attachment #648037 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/90495de76df0
Assignee: nobody → bjacob
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/90495de76df0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

3 years ago
Depends on: 1080277
You need to log in before you can comment on or make changes to this bug.