Closed
Bug 1080291
Opened 10 years ago
Closed 10 years ago
Streamline tools/footprint/
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(5 files)
9.54 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
11.30 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
1.65 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
63.79 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
634 bytes,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
tools/footprint/ has a bunch of stuff in it. The only thing that *might* still be useful is leak-gauge.
Assignee | ||
Updated•10 years ago
|
Summary: [meta] Audit and streamline our memory tools and their documentation → Streamline tools/footprint/
Assignee | ||
Comment 1•10 years ago
|
||
This file doesn't compile, hasn't been touched (except for a license change) since the Mercurial import in 2007, and froydnj thinks that you could probably get the same info from readelf.
Attachment #8502157 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•10 years ago
|
||
This file doesn't compile, hasn't been touched (except for a license change) since the Mercurial import in 2007, and doesn't seem useful -- one of those ideas that sounds cute but in practice gives you no actionable information.
Attachment #8502162 -
Flags: review?(dbaron)
Assignee | ||
Comment 3•10 years ago
|
||
This script at least works, but still doesn't seem useful.
Attachment #8502163 -
Flags: review?(dbaron)
Assignee | ||
Comment 4•10 years ago
|
||
Have a look at README.reports. I'd be shocked if this (a) still worked, and (b) was useful.
Attachment #8502165 -
Flags: review?(dbaron)
Assignee | ||
Comment 5•10 years ago
|
||
Now that leak-gauge is the only thing left in this directory, let's rename. (I'd be happy to remove leak-gauge too, if it's no longer useful.)
Attachment #8502166 -
Flags: review?(dbaron)
Comment 6•10 years ago
|
||
foldelf.cpp hasn't had any substantial changes since 2001: https://github.com/mozilla/gecko-dev/commits/86ab111afb36ef08fbbd265be93b37e7152d9bfe/tools/footprint/foldelf.cpp
Assignee | ||
Comment 7•10 years ago
|
||
> foldelf.cpp hasn't had any substantial changes since 2001:
That's true for everything in that directory except leak-gauge, AFAICT.
Comment 8•10 years ago
|
||
Comment on attachment 8502157 [details] [diff] [review] (part 1) - Remove foldelf.cpp Review of attachment 8502157 [details] [diff] [review]: ----------------------------------------------------------------- As written on irc: foldelf looks useless to me. It looks like it's trying to count duplicate symbols. But it does it pretty badly. And what it wanted to account for is nowadays handled by ICF anyways.
Attachment #8502157 -
Flags: review?(dbaron) → review+
Comment on attachment 8502162 [details] [diff] [review] (part 2) - Remove thrashview.cpp Of the things in here, this is the one I'm saddest to see go. It was an awesome visualization of memory fragmentation. But it's probably true that nobody's used it for 13 or 14 years. And I'm not sure where the input to it is supposed to come from.
Attachment #8502162 -
Flags: review?(dbaron) → review+
Attachment #8502163 -
Flags: review?(dbaron) → review+
Attachment #8502165 -
Flags: review?(dbaron) → review+
Comment on attachment 8502166 [details] [diff] [review] (part 5) - Rename tools/footprint/ as tools/leak-gauge/ For the record, I do still use the perl version occasionally. I should probably update the links in http://dbaron.org/log/2006-01#e20060110a and http://dbaron.org/log/2006-01#e20060114a
Attachment #8502166 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 11•10 years ago
|
||
> For the record, I do still use the perl version occasionally.
Should I remove the HTML version? I don't like the code duplication...
Flags: needinfo?(dbaron)
I'd probably prefer to leave it, if you don't mind.
Flags: needinfo?(dbaron)
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0913bc62172b https://hg.mozilla.org/integration/mozilla-inbound/rev/90c895fa9a9d https://hg.mozilla.org/integration/mozilla-inbound/rev/19a3b5083aaa https://hg.mozilla.org/integration/mozilla-inbound/rev/332966bc7aa2 https://hg.mozilla.org/integration/mozilla-inbound/rev/43f4a2c51d8a
https://hg.mozilla.org/mozilla-central/rev/0913bc62172b https://hg.mozilla.org/mozilla-central/rev/90c895fa9a9d https://hg.mozilla.org/mozilla-central/rev/19a3b5083aaa https://hg.mozilla.org/mozilla-central/rev/332966bc7aa2 https://hg.mozilla.org/mozilla-central/rev/43f4a2c51d8a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•