Streamline tools/footprint/

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla35
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

4 years ago
tools/footprint/ has a bunch of stuff in it. The only thing that *might* still be useful is leak-gauge.
(Assignee)

Updated

4 years ago
Summary: [meta] Audit and streamline our memory tools and their documentation → Streamline tools/footprint/
(Assignee)

Comment 1

4 years ago
Created attachment 8502157 [details] [diff] [review]
(part 1) - Remove foldelf.cpp

This file doesn't compile, hasn't been touched (except for a license change)
since the Mercurial import in 2007, and froydnj thinks that you could probably
get the same info from readelf.
Attachment #8502157 - Flags: review?(dbaron)
(Assignee)

Comment 2

4 years ago
Created attachment 8502162 [details] [diff] [review]
(part 2) - Remove thrashview.cpp

This file doesn't compile, hasn't been touched (except for a license change)
since the Mercurial import in 2007, and doesn't seem useful -- one of those
ideas that sounds cute but in practice gives you no actionable information.
Attachment #8502162 - Flags: review?(dbaron)
(Assignee)

Comment 3

4 years ago
Created attachment 8502163 [details] [diff] [review]
(part 3) - Remove watch.sh

This script at least works, but still doesn't seem useful.
Attachment #8502163 - Flags: review?(dbaron)
(Assignee)

Comment 4

4 years ago
Created attachment 8502165 [details] [diff] [review]
(part 4) - Remove Gross Dynamic Footprint Reports code

Have a look at README.reports. I'd be shocked if this (a) still worked, and (b)
was useful.
Attachment #8502165 - Flags: review?(dbaron)
(Assignee)

Comment 5

4 years ago
Created attachment 8502166 [details] [diff] [review]
(part 5) - Rename tools/footprint/ as tools/leak-gauge/

Now that leak-gauge is the only thing left in this directory, let's rename.

(I'd be happy to remove leak-gauge too, if it's no longer useful.)
Attachment #8502166 - Flags: review?(dbaron)
(Assignee)

Comment 7

4 years ago
> foldelf.cpp hasn't had any substantial changes since 2001:

That's true for everything in that directory except leak-gauge, AFAICT.
Comment on attachment 8502157 [details] [diff] [review]
(part 1) - Remove foldelf.cpp

Review of attachment 8502157 [details] [diff] [review]:
-----------------------------------------------------------------

As written on irc:
foldelf looks useless to me. It looks like it's trying to count duplicate symbols. But it does it pretty badly. And what it wanted to account for is nowadays handled by ICF anyways.
Attachment #8502157 - Flags: review?(dbaron) → review+
Comment on attachment 8502162 [details] [diff] [review]
(part 2) - Remove thrashview.cpp

Of the things in here, this is the one I'm saddest to see go.  It was an awesome visualization of memory fragmentation.  But it's probably true that nobody's used it for 13 or 14 years.  And I'm not sure where the input to it is supposed to come from.
Attachment #8502162 - Flags: review?(dbaron) → review+
Attachment #8502163 - Flags: review?(dbaron) → review+
Attachment #8502165 - Flags: review?(dbaron) → review+
Comment on attachment 8502166 [details] [diff] [review]
(part 5) - Rename tools/footprint/ as tools/leak-gauge/

For the record, I do still use the perl version occasionally.

I should probably update the links in http://dbaron.org/log/2006-01#e20060110a and http://dbaron.org/log/2006-01#e20060114a
Attachment #8502166 - Flags: review?(dbaron) → review+
(Assignee)

Comment 11

4 years ago
> For the record, I do still use the perl version occasionally.

Should I remove the HTML version? I don't like the code duplication...
Flags: needinfo?(dbaron)
I'd probably prefer to leave it, if you don't mind.
Flags: needinfo?(dbaron)
You need to log in before you can comment on or make changes to this bug.