Closed
Bug 1080341
Opened 10 years ago
Closed 10 years ago
Remove --enable-wrap-malloc/--with-wrap-malloc
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
5.27 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
With bug 1077366, --enable-wrap-malloc is not abused anymore for android linkage. Other than android linkage, the option has been of limited usefulness since bug 804303 (replace-malloc), which allows runtime wrapping. In fact, chances are --enable-wrap-malloc breaks things with jemalloc integration. This doesn't, however, remove those options from standalone js builds, although it's not clear they're any useful there either.
Attachment #8502250 -
Flags: review?(mshal)
Comment 2•10 years ago
|
||
Comment on attachment 8502250 [details] [diff] [review] Remove --enable-wrap-malloc/--with-wrap-malloc Looks like there is still one definition of _WRAP_MALLOC that can be removed as well: if test -z "$gonkdir"; then _WRAP_MALLOC=1
Attachment #8502250 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2) > Comment on attachment 8502250 [details] [diff] [review] > Remove --enable-wrap-malloc/--with-wrap-malloc > > Looks like there is still one definition of _WRAP_MALLOC that can be removed > as well: > > if test -z "$gonkdir"; then > _WRAP_MALLOC=1 That one is removed in bug 1077366, which this depends on and is not landed yet.
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f12339a485
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03f12339a485
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•