1080341 - Remove --enable-wrap-malloc/--with-wrap-malloc

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove --enable-wrap-malloc/--with-wrap-malloc

With bug 1077366, --enable-wrap-malloc is not abused anymore for android
linkage. Other than android linkage, the option has been of limited
usefulness since bug 804303 (replace-malloc), which allows runtime wrapping.

In fact, chances are --enable-wrap-malloc breaks things with jemalloc
integration.

This doesn't, however, remove those options from standalone js builds,
although it's not clear they're any useful there either.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8502250 [details] [diff] [review]
Remove --enable-wrap-malloc/--with-wrap-malloc

Looks like there is still one definition of _WRAP_MALLOC that can be removed as well:

    if test -z "$gonkdir"; then
      _WRAP_MALLOC=1

Comment 3

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8502250 [details] [diff] [review]
> Remove --enable-wrap-malloc/--with-wrap-malloc
> 
> Looks like there is still one definition of _WRAP_MALLOC that can be removed
> as well:
> 
>     if test -z "$gonkdir"; then
>       _WRAP_MALLOC=1

That one is removed in bug 1077366, which this depends on and is not landed yet.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03f12339a485

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03f12339a485