1080487 - Revert bug 990214, to re-introduce deletion of webapps during cleanup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[Zac C (:zac)]

Attachment: github pr

Comment 2

[Florin Strugariu [:Bebe]]

Zac do we have a unit test that checks that the app is deleted? If not can you add one?

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8502424 [details] [review]
github pr

I can confirm this removes the installed apps, thanks.

I guess this could be tested by having one testcase install an app and then the second one check that it isn't there anymore?

Comment 4

[Zac C (:zac)]

(In reply to Florin Strugariu [:Bebe] from comment #2)
> Zac do we have a unit test that checks that the app is deleted? If not can
> you add one?

If I can do it easily I will try to incorporate it into test_cleanup_gaia but it might be messy.

Comment 5

[Zac C (:zac)]

(In reply to Florin Strugariu [:Bebe] from comment #2)
> Zac do we have a unit test that checks that the app is deleted? If not can
> you add one?

I don't think this is a candidate for a unit test because it relies on b2g being restarted and I think that will be a bit too long or a bit heavy for this purpose.

We should however probably have a unit test for apps.uninstall and apps.install.

Comment 6

[Zac C (:zac)]

Adhoc job here:
http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/192/

If it's OK we'll merge on Monday.

Comment 7

[Zac C (:zac)]

http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/193/

Comment 8

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/83779ff088c794606c00f98851ada88402cb55dd