1080838 - Participants not removed on leaving a channel

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

Despite the QUIT message being received and apparently handled without error, the participant is not removed from the room. On rejoin, there is obviously a "trying to add chat buddy twice" error.

Comment 1

[aleth [:aleth]]

I wonder if this is somehow due to receiving a WATCH 601 before QUIT?

Comment 2

[aleth [:aleth]]

So the problem here is that ircAccount.userPrefixes (used for normalizing purposes) is fixed but iSUPPORT PREFIX can extend the actual list of userPrefixes (userPrefixToModeMap), leading to mismatches.

Comment 3

[aleth [:aleth]]

Attachment: userprefixupdate.diff

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8507392 [details] [diff] [review]
userprefixupdate.diff

Review of attachment 8507392 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for debugging this!

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/fd014df4dd07

Again, should we backport this to TB 31? Thanks for fixing this!

Comment 6

[Florian Quèze [:florian]]

Here too, I would say yes.

Comment 7

[aleth [:aleth]]

We'd like to uplift this to TB31 as it badly affects IRC on inspircd servers such as, since recently, moznet. There doesn't seem to be an appropriate flag to set as this bug is not in the TB component, so using needinfo.

Comment 8

[Mark Banner (:standard8)]

(In reply to aleth [:aleth] from comment #7)
> We'd like to uplift this to TB31 as it badly affects IRC on inspircd servers
> such as, since recently, moznet. There doesn't seem to be an appropriate
> flag to set as this bug is not in the TB component, so using needinfo.

See bug 1078223 comment 12

Comment 9

[aleth [:aleth]]

Comment on attachment 8507392 [details] [diff] [review]
userprefixupdate.diff

[Approval Request Comment]
User impact if declined: incorrect participant list entries, subsequent UI breakage
Testing completed (on c-c, etc.): works well
Risk to taking this patch (and alternatives if risky): none I can think of

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/c286aae15d96

Comment 11

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/759077ce09b6

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/107a8daec69b