Closed Bug 1080838 Opened 6 years ago Closed 6 years ago

Participants not removed on leaving a channel

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(thunderbird34 fixed, thunderbird35 fixed, thunderbird_esr3134+ fixed)

RESOLVED FIXED
Tracking Status
thunderbird34 --- fixed
thunderbird35 --- fixed
thunderbird_esr31 34+ fixed

People

(Reporter: aleth, Assigned: aleth)

Details

(Keywords: regression, Whiteboard: [1.6-blocking])

Attachments

(1 file)

Despite the QUIT message being received and apparently handled without error, the participant is not removed from the room. On rejoin, there is obviously a "trying to add chat buddy twice" error.
Whiteboard: [1.6-blocking]
I wonder if this is somehow due to receiving a WATCH 601 before QUIT?
So the problem here is that ircAccount.userPrefixes (used for normalizing purposes) is fixed but iSUPPORT PREFIX can extend the actual list of userPrefixes (userPrefixToModeMap), leading to mismatches.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8507392 - Flags: review?(clokep)
Comment on attachment 8507392 [details] [diff] [review]
userprefixupdate.diff

Review of attachment 8507392 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for debugging this!
Attachment #8507392 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/fd014df4dd07

Again, should we backport this to TB 31? Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Here too, I would say yes.
We'd like to uplift this to TB31 as it badly affects IRC on inspircd servers such as, since recently, moznet. There doesn't seem to be an appropriate flag to set as this bug is not in the TB component, so using needinfo.
Flags: needinfo?(standard8)
(In reply to aleth [:aleth] from comment #7)
> We'd like to uplift this to TB31 as it badly affects IRC on inspircd servers
> such as, since recently, moznet. There doesn't seem to be an appropriate
> flag to set as this bug is not in the TB component, so using needinfo.

See bug 1078223 comment 12
Flags: needinfo?(standard8)
Comment on attachment 8507392 [details] [diff] [review]
userprefixupdate.diff

[Approval Request Comment]
User impact if declined: incorrect participant list entries, subsequent UI breakage
Testing completed (on c-c, etc.): works well
Risk to taking this patch (and alternatives if risky): none I can think of
Attachment #8507392 - Flags: approval-comm-esr31?
Attachment #8507392 - Flags: approval-comm-beta?
Attachment #8507392 - Flags: approval-comm-aurora?
Attachment #8507392 - Flags: approval-comm-beta?
Attachment #8507392 - Flags: approval-comm-beta+
Attachment #8507392 - Flags: approval-comm-aurora?
Attachment #8507392 - Flags: approval-comm-aurora+
Attachment #8507392 - Flags: approval-comm-esr31? → approval-comm-esr31+
You need to log in before you can comment on or make changes to this bug.