Closed Bug 1080851 Opened 10 years ago Closed 10 years ago

Fix jemalloc3 builds with -Werror=implicit-int

Categories

(Core :: Memory Allocator, defect)

Product:
Core
Component:
Memory Allocator
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ggp, Assigned: ggp)

References

Details

Over at bug 1076698, enabling -Werror=implicit-int for the whole tree broke jemalloc3 builds (see comment 17 there).

The quick solution was to just disable the switch, but it looks like the best long-term fix would be to upstream a trivial patch that silences the warning, or find a way to not request the warning when building jemalloc3 specifically.
I opened a pull request to fix this upstream: https://github.com/jemalloc/jemalloc/pull/154
Blocks: 1076698
Assignee: nobody → ggoncalves
This has been merged upstream, and should be fixed when we next update our jemalloc clone.
Depends on: 1094275
I've just confirmed that this is fixed by bug 1094275. It should be safe to re-enable -Werror=implicit-int in bug 1076698 if still applicable.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.