Update the in-tree copy of jemalloc3

RESOLVED FIXED in mozilla37

Status

()

Core
Memory Allocator
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ggp, Assigned: ggp)

Tracking

unspecified
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

3 years ago
We need some of the recent changes to jemalloc3 in order to solve the remaining blockers for bug 762449.
(Assignee)

Updated

3 years ago
Blocks: 801536
(Assignee)

Updated

3 years ago
Blocks: 899126
(Assignee)

Updated

3 years ago
Blocks: 1080851
(Assignee)

Updated

3 years ago
Blocks: 762448
Could you attach the jemalloc 3 update patch here, or at least give the commit sha1 for what the other patches are based on?
Flags: needinfo?(ggoncalves)
(Assignee)

Comment 2

3 years ago
Created attachment 8534309 [details] [diff] [review]
Update the in-tree copy of jemalloc3.

Sure, here it is. I'm on 879e76a9e57 for now.
(Assignee)

Comment 3

3 years ago
Created attachment 8534310 [details] [diff] [review]
Include the WIP bookkeeping patch for jemalloc.

Oh, and here's a patch that imports a slightly outdated version of my bookkeeping patch for
bug 899126. I'm keeping it separate as we'll hopefully get that change upstreamed.
(Assignee)

Updated

3 years ago
Flags: needinfo?(ggoncalves)
(Assignee)

Updated

3 years ago
Depends on: 1108045
Can you refresh with current master, which contains the fix for bug 1108045? Then let's start the party by landing this.
(Assignee)

Comment 5

3 years ago
Created attachment 8537145 [details] [diff] [review]
Update the in-tree copy of jemalloc3.

Sure, here it is.
Attachment #8534309 - Attachment is obsolete: true
Attachment #8537145 - Flags: review?(mh+mozilla)
(Assignee)

Comment 6

3 years ago
Created attachment 8537146 [details] [diff] [review]
Patch jemalloc3 so it computes bookkeeping.

And here's the updated bookkeeping patch if you want to include it now too. Feel free to cancel
the review if you don't.
Attachment #8534310 - Attachment is obsolete: true
Attachment #8537146 - Flags: review?(mh+mozilla)
(Assignee)

Comment 7

3 years ago
Created attachment 8537339 [details] [diff] [review]
Update the in-tree copy of jemalloc3.

The previous patch builds on all architectures, but fails static rooting analysis on B2G Desktop Linux x64 [1]. This new version incorporates a patch by :sfink that fixes that [2].

1- https://treeherder.mozilla.org/#/jobs?repo=try&revision=336acb2b8869
2- https://treeherder.mozilla.org/#/jobs?repo=try&revision=55d9754cb127
Attachment #8537145 - Attachment is obsolete: true
Attachment #8537145 - Flags: review?(mh+mozilla)
Attachment #8537339 - Flags: review?(mh+mozilla)
Comment on attachment 8537146 [details] [diff] [review]
Patch jemalloc3 so it computes bookkeeping.

Shouldn't this be in bug 899126?
Comment on attachment 8537339 [details] [diff] [review]
Update the in-tree copy of jemalloc3.

Review of attachment 8537339 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5b1a8e8aee4
Attachment #8537339 - Flags: review?(mh+mozilla) → review+
Depends on: 1112434
https://hg.mozilla.org/mozilla-central/rev/b5b1a8e8aee4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1112566

Updated

3 years ago
Depends on: 1113408
Comment on attachment 8537146 [details] [diff] [review]
Patch jemalloc3 so it computes bookkeeping.

I'll leave a comment about this patch in bug 899126. Sorry it took so long.
Attachment #8537146 - Attachment is obsolete: true
Attachment #8537146 - Flags: review?(mh+mozilla)
(Assignee)

Updated

3 years ago
Blocks: 1108045
No longer depends on: 1108045

Updated

3 years ago
Depends on: 1115793
Depends on: 1120798
You need to log in before you can comment on or make changes to this bug.