1080956 - SWF #107 has rendering issues and loops too early

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect, P2)

Description

[Chris Peterson [:cpeterson]]

The ad plays until the show shows up and then hangs with a slow script error, followed by a TypeError

http://swf.codeazur.com.br/archive/ab/73/95/11/ab739511300505fed294a5adf225ac32b3b10e801d86d5b30839838651eb21de.swf


Error: Script terminated by timeout at:
BucketAllocator</BucketAllocator.prototype.allocate@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:11216:1
Canvas2DSurface</Canvas2DSurface.prototype.allocate@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14482:34
SimpleAllocator</SimpleAllocator.prototype.allocate@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:11275:38
Canvas2DStageRenderer</Canvas2DStageRenderer.prototype._renderToSurfaceRegion@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14640:42
visitFrame@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14759:46
Frame</Frame.prototype.visit@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:11713:34
Canvas2DStageRenderer</Canvas2DStageRenderer.prototype._renderFrame@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14699:1
visitFrame@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14785:29
Frame</Frame.prototype.visit@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:11713:34
Canvas2DStageRenderer</Canvas2DStageRenderer.prototype._renderFrame@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14699:1
Canvas2DStageRenderer</Canvas2DStageRenderer.prototype.renderFrame@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14625:1
Canvas2DStageRenderer</Canvas2DStageRenderer.prototype.render@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:14601:21
Easel</Easel.prototype._render@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:15218:25
Easel</Easel.prototype.render@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:15227:17
tick@http://www.areweflashyet.com/shumway/build/bundles/shumway.gfx.js:15187:21


TypeError:  shumway.player.js:56384
Error:  shumway.player.js:56385
"AVM1 error: TypeError: symbol is undefined" shumway.player.js:56386

Comment 1

[Chris Peterson [:cpeterson]]

This is a slow script error in the gfx backend that only happens in the SWF Inspector, not the Shumway extension.

Comment 2

[Till Schneidereit [:till]]

This particular issue is fixed. The ad still doesn't display correctly and loops too early, so re-purposing this bug. Not an m4-blocker without the iloop in GFX-land.

Comment 3

[Yury Delendik (:yury)]

Also SWF #2

Created a smaller test case at https://github.com/mozilla/shumway/tree/master/test/swfs/avm1/doactionorder -- it is connected with order of doaction and placeobject element. Flash IDE cannot produce such SWFs, probably some other tool generated them.

Comment 4

[Chris Peterson [:cpeterson]]

The order of execution of AVM1 action blocks should block M3. Tobias is fixing this.

Comment 5

[Tobias Schneider [:tobytailor]]

Execution order fixed in https://github.com/mozilla/shumway/pull/2252. Together with a follow-up fix in https://github.com/mozilla/shumway/pull/2256 this file now works except almost perfectly. The last remaining visual issue is tracked via https://bugzilla.mozilla.org/show_bug.cgi?id=1167019, but shouldn't block M3.