1081079 - Create a React mixin for dealing with document title updates

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

A bit along the lines of this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1078718#c3, I think we should create a react mixin for dealing with document title updates. 

That would make things cleaner and easier to test.

Comment 1

[Mark Banner (:standard8)]

P2 as this is already in progress, we have a mixin, we should just use it everywhere (it'd also fix some issues which we already have).

Comment 2

[Mark Banner (:standard8)]

Attachment: Use the DocumentTitleMixin for Loop in more places.

This is ready to land, but depends on the patches in bug 1140481 / bug 1088672. Hence I'll wait until they've landed before requesting review.

This is enough that we can close this bug - the remaining work is wontfix as it covers the standalone call url items which will hopefully go away soon.

Comment 3

[Mark Banner (:standard8)]

Attachment: Use the DocumentTitleMixin for Loop in more places.

Now that the deps have landed, this patch is ready for review. I've not done the standalone call url uses - they are effectively wontfix.

For now, this will save some of our titles being messed up.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8576663 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

Dan isn't around for the next couple of days...

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8576663 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

Review of attachment 8576663 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but the DocumentTitleMixin seems almost too simple, like I actually don't see much value in it. It just adds a lot of indirection for the code.

Comment 6

[Mark Banner (:standard8)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> r=me but the DocumentTitleMixin seems almost too simple, like I actually
> don't see much value in it. It just adds a lot of indirection for the code.

I find the value all in the testability - it makes testing it much simpler, and means we're not messing with the live document (and hence, things like ui-showcase end up with the right title).

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/448e02bb2620

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/448e02bb2620