All users were logged out of Bugzilla on October 13th, 2018

Create a React mixin for dealing with document title updates

RESOLVED FIXED in Firefox 39

Status

P2
minor
Rank:
21
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: NiKo, Assigned: standard8)

Tracking

unspecified
mozilla39
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment, 1 obsolete attachment)

A bit along the lines of this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1078718#c3, I think we should create a react mixin for dealing with document title updates. 

That would make things cleaner and easier to test.
Whiteboard: [tech-debt]

Updated

4 years ago
backlog: --- → Fx36+

Updated

4 years ago
backlog: Fx36+ → Fx37+
Assignee: nobody → standard8

Updated

4 years ago
backlog: Fx37+ → Fx38?
P2 as this is already in progress, we have a mixin, we should just use it everywhere (it'd also fix some issues which we already have).
backlog: Fx38? → tech-debt
Priority: -- → P2
Created attachment 8575209 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

This is ready to land, but depends on the patches in bug 1140481 / bug 1088672. Hence I'll wait until they've landed before requesting review.

This is enough that we can close this bug - the remaining work is wontfix as it covers the standalone call url items which will hopefully go away soon.
Iteration: --- → 39.2 - 23 Mar
Points: --- → 2
Created attachment 8576663 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

Now that the deps have landed, this patch is ready for review. I've not done the standalone call url uses - they are effectively wontfix.

For now, this will save some of our titles being messed up.
Attachment #8575209 - Attachment is obsolete: true
Attachment #8576663 - Flags: review?(dmose)

Updated

4 years ago
Rank: 21
Flags: firefox-backlog+
Comment on attachment 8576663 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

Dan isn't around for the next couple of days...
Attachment #8576663 - Flags: review?(dmose) → review?(jaws)
Comment on attachment 8576663 [details] [diff] [review]
Use the DocumentTitleMixin for Loop in more places.

Review of attachment 8576663 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but the DocumentTitleMixin seems almost too simple, like I actually don't see much value in it. It just adds a lot of indirection for the code.
Attachment #8576663 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> r=me but the DocumentTitleMixin seems almost too simple, like I actually
> don't see much value in it. It just adds a lot of indirection for the code.

I find the value all in the testability - it makes testing it much simpler, and means we're not messing with the live document (and hence, things like ui-showcase end up with the right title).
https://hg.mozilla.org/integration/fx-team/rev/448e02bb2620
Flags: in-testsuite+
Target Milestone: --- → mozilla39
https://hg.mozilla.org/mozilla-central/rev/448e02bb2620
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.