Closed Bug 1081095 Opened 10 years ago Closed 10 years ago

Fix a couple of issues on the standalone start page with Firefox Hello information

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
1

Tracking

(firefox35 fixed)

RESOLVED FIXED
mozilla35
Iteration:
35.3
Tracking Status
firefox35 --- fixed

People

(Reporter: standard8, Assigned: jaws)

References

Details

Attachments

(1 file)

Following the previous changes, I noticed a couple of issues on the standalone page when testing locally:

- The main title in the window is "FirefoxFirefox Hello"
- The Terms of Service information still references "this product" rather than "Firefox Hello"

I'll get a patch up for these as soon as I've confirmed with Darrin what is required from a ux perspective for the title.
Huh, in my testing I only saw "Firefox Hello", but RT said that just "Firefox Hello" for the standalone page title is good. (https://bugzilla.mozilla.org/show_bug.cgi?id=1070753#c11)
Flags: qe-verify-
Attached patch PatchSplinter Review
Fixed and tested locally.
Assignee: standard8 → jaws
Status: NEW → ASSIGNED
Attachment #8503540 - Flags: review?(dmose)
Flags: in-testsuite-
Flags: firefox-backlog+
Comment on attachment 8503540 [details] [diff] [review]
Patch

Review of attachment 8503540 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8
Attachment #8503540 - Flags: review?(dmose) → review+
I landed this, as I want to give it time to get into the tree for a loop-client release tomorrow.

https://hg.mozilla.org/integration/fx-team/rev/58a7392bde36
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/58a7392bde36
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.