1081095 - Fix a couple of issues on the standalone start page with Firefox Hello information

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Following the previous changes, I noticed a couple of issues on the standalone page when testing locally:

- The main title in the window is "FirefoxFirefox Hello"
- The Terms of Service information still references "this product" rather than "Firefox Hello"

I'll get a patch up for these as soon as I've confirmed with Darrin what is required from a ux perspective for the title.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Huh, in my testing I only saw "Firefox Hello", but RT said that just "Firefox Hello" for the standalone page title is good. (https://bugzilla.mozilla.org/show_bug.cgi?id=1070753#c11)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Fixed and tested locally.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8503540 [details] [diff] [review]
Patch

Review of attachment 8503540 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 4

[Mark Banner (:standard8)]

I landed this, as I want to give it time to get into the tree for a loop-client release tomorrow.

https://hg.mozilla.org/integration/fx-team/rev/58a7392bde36

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58a7392bde36