1070753 - Standalone Client's title is still "Loop"

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

The title of the standalone link-clicker UI is still just "Loop".

We should either change it to "Firefox WebRTC" (or product name), or do we want some combination of, for example "In call - Firefox WebRTC", with the "In call" part updating appropriately.

Darrin, any thoughts here?

Comment 1

[Darrin Henein [:darrin]]

I would reverse the order, so it reads "<product name> - <status>"... as for what product name we are using when/where, i defer to Arcadio.

Comment 2

[:shell escalante]

Arcadio - just checking that on Link clicker we want to say "Firefox Hello - <status>" versus <Hello - <status>".... so that folks receiving the link and clicking on it see our brand and product name??

Your call - just adapt user story if just product name is better.

Comment 4

[Romain Testard [:RT]]

Adding NI to Arcadio for confirmation.

Comment 5

[Romain Testard [:RT]]

Just talked to Arcadio who confirmed we can use the "Firefox Hello" name.
This bug is then to replace "Loop" by "Firefox Hello - <status>".

Comment 6

[Mark Banner (:standard8)]

Clearing NI request per comment 5.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

What are we going to put for the <status>? I assume it is things like {"Start Conversation", "In Conversation", "Conversation Ended"}, but we don't have all of those strings yet.

The closest we have is "Start conversation?", (missing), and "Your conversation has ended."

Can we go with just putting the product name and no <status> for now? So just "Firefox Hello"?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This patch changes the title of the page to Firefox Hello but leaves off the <status> based on my above comment. I'd rather that we land this now and then we can determine if a follow-up is necessary to add the <status> bits.

I removed the title from about:looppanel since no reasonable person will be loading about:looppanel directly.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

r+ conditional on making the change in the .jsx and then regenerating the js file from that.  A unit test here is probably not worth the effort at this moment.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/39efd3ba7468

Comment 11

[Romain Testard [:RT]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> What are we going to put for the <status>? I assume it is things like
> {"Start Conversation", "In Conversation", "Conversation Ended"}, but we
> don't have all of those strings yet.
> 
> The closest we have is "Start conversation?", (missing), and "Your
> conversation has ended."
> 
> Can we go with just putting the product name and no <status> for now? So
> just "Firefox Hello"?

Yes agreed. I'll create a separate bug for the status once we have the link clicker UI finalized with all call states (we don't have call failed currently)

Comment 12

[Romain Testard [:RT]]

Bug 1081029 now created to track call status implementation in the title.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39efd3ba7468