Closed Bug 1081138 Opened 10 years ago Closed 10 years ago

App Chrome has misplaced forward button

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0M unaffected, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.0M --- unaffected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: benfrancis, Assigned: benfrancis)

References

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(1 file)

Screenshot of misplaced forward button
26.94 KB, image/png
Details 
STR:
* Install Facebook app
* Launch Facebook
* Tap on a hyperlink
* Tap the back button

Expected:
* Forward button displayed to the left of title bar

Actual:
* Forward button displayed above title bar

Reproduceable on both master and 2.1 branches, I suspect this is a fairly recent regression, would be nice to get a regression range. Note that this doesn't reproduce for browser chrome on browser windows, only the app chrome on Facebook, although it appears not to reproduce for the Pinterest app which is odd.
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
status-b2g-v2.0M: --- → unaffected
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → affected
(In reply to Ben Francis [:benfrancis] from comment #1)
> [Blocking Requested - why for this release]:

Broken UI presenting in top tier app.
Taking this
Assignee: nobody → bfrancis
Whiteboard: [systemsfe]
Why is there a qawanted tag on this bug?
Flags: needinfo?(bfrancis)
I was looking for a regression range, but don't worry too much because I think I found the line of code that causes the bug. I just need to figure out what else breaks if I remove it :)
Flags: needinfo?(bfrancis)
Keywords: qawanted
Looks like this was caused by bug 1074028

Guillaume, do you want to back that out again or should we try to find a new fix here?
Depends on: 1074028
Flags: needinfo?(gmarty)
Keywords: regression
Just look at the screenshot
blocking-b2g: 2.1? → 2.1+
I'm going to steal to make sure we have a test here. Also suggest we backout bug 1074028.
Status: NEW → ASSIGNED
Flags: needinfo?(gmarty)
Resolved now that bug 1074028 has been backed out.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: affected → fixed
status-b2g-v2.2: affected → fixed
Resolution: --- → FIXED
Depends on: 1081211
Target Milestone: --- → 2.1 S6 (10oct)
Verified Fixed on Flame 2.1 and Flame 2.2

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Forward button is displayed properly above title bar
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.1: fixed → verified
status-b2g-v2.2: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Kevin, is this covered in the integration test suite you wrote for bug 1081211?
Flags: needinfo?(kgrandon)
Yup! Thanks for the reminder.
Flags: needinfo?(kgrandon) → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: