1081157 - "What is this page" link appears on "blank" version of about:newtab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Matt Brubeck (:mbrubeck)]

Bug 1062256 intentionally added a "What is this page" link to the body of the new tab page.

This link does not make sense when the new tab page is set to "blank" mode.  For example, clicking the link says, "When you open a new tab, you'll see tiles...," which is not true when the page is set to blank.

Also, this link adds clutter and distraction and makes the page less "blank" than it was.  Having a distraction-free option has long been a goal of the new tab page design, going back to the first iterations 5 years ago:
https://blog.mozilla.org/labs/2009/03/firefox-new-tab-page-cognitive-shield/

Therefore, the "What is this page?" link should be hidden when the "blank" option is selected.

Comment 1

[Ed Lee :Mardak]

re: status-firefox33, the UI is turned off for all 33 users but we'll turn it on later in 33.

dcrobot, was your intent of moving the link outside of the menu to have "what is this page" visible on "blank" newtab pages?

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8503258 [details] [diff] [review]
v1

Review of attachment 8503258 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/newtab/newTab.css
@@ +58,5 @@
>  
> +#newtab-scrollbox[page-disabled] #newtab-intro-what {
> +  opacity: 0;
> +  pointer-events: none;
> +}

I think display:none would be better. I can't exactly remember why the grid uses opacity/pointer-events but I think it had something to do with transitions and moving tiles around.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/d3ed7981bd8f

Comment 5

[Aaron]

Yes, Ed, that is correct. That link should remain present for all 3 views (enhanced, classic, blank).

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d3ed7981bd8f

Comment 7

[Matt Brubeck (:mbrubeck)]

(In reply to Aaron from comment #5)
> Yes, Ed, that is correct. That link should remain present for all 3 views
> (enhanced, classic, blank).

Do you have any comment on the reasons given in comment 0 to hide it when "blank" is selected?  The text really doesn't make any sense for users who have disabled tiles.

Should this be uplifted to beta/aurora?

Comment 8

[Aaron]

After thinking about this further, I agree with you Ed. Let's drop "What is this page?" from the Blank New Tab view.

Comment 9

[Matt Brubeck (:mbrubeck)]

[Tracking Requested - why for this release]: Part of the 33.x tiles release.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

33.1, tracking!

Comment 11

[Ed Lee :Mardak]

Attachment: for aurora/beta/release uplift

Approval Request Comment
[Feature/regressing bug #]: Bug 1062256
[User impact if declined]: Users expecting a blank experience will see some text
[Describe test coverage new/current, TBPL]: manual QE verification
[Risks and why]: Low - simple css change similar to existing css rules
[String/UUID change made/needed]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f3d0612bdba
https://hg.mozilla.org/releases/mozilla-beta/rev/c00a4cfe83e9
https://hg.mozilla.org/releases/mozilla-release/rev/d69a0e8a853d

Comment 13

[vasilicamihasca]

I was able to reproduce this bug on Nightly 35.0a1 (2014-10-11), using Windows 7 x64.

Verified fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 14.04 x86 using Nightly 36.0a1 (2014-10-21), Aurora 35.0a2 (2014-10-21) and Beta 34.0b2 (20141020184313).

This fix can be marked as verified.

[bugday-20141022]

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Updating tracking flags according to comment 13.

Thank you!

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Also verified this on the elder branch, build ID: 20141021103730.