Closed
Bug 1081296
Opened 10 years ago
Closed 10 years ago
Translation - Add sumo link for promotional doorhanger
Categories
(Firefox :: Translations, defect)
Firefox
Translations
Tracking
()
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(2 files)
2.25 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
2.49 KB,
patch
|
Felipe
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1072740 +++ Follow-up from bug 1072740: add sumo link and don't display the promotional doorhanger unless we are in the foreground tab
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8503383 -
Flags: review?(florian)
Updated•10 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify? → qe-verify+
Comment 2•10 years ago
|
||
Comment on attachment 8503383 [details] [diff] [review] Patch Review of attachment 8503383 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/translation/translation-infobar.xml @@ +31,5 @@ > anonid="welcomeHeadline"/> > <xul:description class="translation-welcome-body" anonid="welcomeBody"/> > <xul:hbox align="center"> > + <xul:label anonid="learnMore" class="plain text-link" > + onclick="openUILinkIn('https://support.mozilla.org/en-US/products/firefox/automatic-translation', 'tab');this.parentNode.parentNode.parentNode.hidePopup();"/> nit: I would probably add a space or maybe even a line break after the first ';'.
Attachment #8503383 -
Flags: review?(florian) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e779f1cf1d9
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8503383 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: Follow-up to bug 1072740 because we didn't have the URL to be used before that bug landed. This makes the "Learn more" link functional. [User impact if declined]: "Learn more" from bug 1072740 won't work. [Describe test coverage new/current, TBPL]: Landed on inbound, manually tested [Risks and why]: Limited to the new promotional doorhanger [String/UUID change made/needed]: None
Attachment #8503383 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3e779f1cf1d9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
Comment 6•10 years ago
|
||
Comment on attachment 8503383 [details] [diff] [review] Patch Review of attachment 8503383 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/translation/translation-infobar.xml @@ +31,5 @@ > anonid="welcomeHeadline"/> > <xul:description class="translation-welcome-body" anonid="welcomeBody"/> > <xul:hbox align="center"> > + <xul:label anonid="learnMore" class="plain text-link" > + onclick="openUILinkIn('https://support.mozilla.org/en-US/products/firefox/automatic-translation', 'tab');this.parentNode.parentNode.parentNode.hidePopup();"/> Is this link correct? 1. I think the recommendation is not to include the "en-US" segment of the URL. i.e. https://support.mozilla.org/products/firefox/automatic-translation 2. The URL results in a page not found. Maybe it just hasn't been published yet (although I don't see a draft either.)
Updated•10 years ago
|
Flags: needinfo?(felipc)
Assignee | ||
Comment 7•10 years ago
|
||
Good catch about the en-US, I had forgotten to remove it. I created a new article on Sumo and after talking with folks on #sumo I was under impression that that would be the final URL, but I see that my article was created in https://support.mozilla.org/kb/automatic-translation . I think the URL doesn't matter much so there's no need to change the one that has already been created, so I'll change it in the patch to point to the correct one.
Flags: needinfo?(felipc)
Assignee | ||
Comment 8•10 years ago
|
||
Approval Request Comment Patch for aurora with updated URL
Attachment #8503686 -
Flags: review+
Attachment #8503686 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•10 years ago
|
Attachment #8503383 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 9•10 years ago
|
||
Updated URL on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb718391722
Comment 11•10 years ago
|
||
Comment on attachment 8503686 [details] [diff] [review] Patch for aurora Aurora+
Attachment #8503686 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
QA Contact: bogdan.maris
Comment 13•10 years ago
|
||
Tested using latest Aurora and latest Nightly on Windows 7 64bit, Ubuntu 14.04 32bit and Mac OS X 10.9.5, "Learn more" string redirects to https://support.mozilla.org/kb/automatic-translation.
You need to log in
before you can comment on or make changes to this bug.
Description
•