1081562 - [Camera] The share button in camera preview is difficult to tap

Status: RESOLVED DUPLICATE of bug 1081319

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

Description:
The touch area of the share and ellipses buttons in the camera preview seems to be too low. Tapping the buttons is difficult, and the user must tap lower than expected to try and activate the hit box.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141011000201
2) Enter the camera app
3) Take a picture or video
4) Enter the preview of the picture
5) Try and touch the share button
  
Actual:
The share and ellipses button in the camera preview are difficult to tap.
  
Expected: 
Buttons are easy for the user to tap.
  
Environmental Variables:
Device: Flame 2.1 KK (319 MB)
BuildID: 20141011000201 (full flash)
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 100%
See attached: Logcat

Comment 1

[Rachel Pribble [:rpribble]]

This issue also occurs on v2.2.

Environmental Variables:
Device: Flame 2.2 Master KK (319 MB)
BuildID: 20141011040204 (full flash)
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The share and ellipses button in the camera preview are difficult to tap.

Comment 2

[Rachel Pribble [:rpribble]]

This bug fails verification of bug 1076158.

Comment 3

[Punam Dahiya [:pdahiya]]

Taking bug to investigate and fix. This issue is seen in Video and Camera app which has full screen mode.It appears in Video and camera app the area where the status bar icons normally are (top right) is not receiving touch events.

Messaging app doesn't do full screen mode and has status bar on top and not seeing this issue. On flashing messaging app in full screen mode using below steps, I can replicate this issue in messaging app
a) Add   "fullscreen": true to manifest.webapp
b) Flash Flame using make reset-gaia GAIA_DEV_PIXELS_PER_PX=1.5

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of bug 1081562

Hi Alive
Attached PR removes explicit set of pointer-events: auto; on div inside status-bar, this improves responsiveness in options icon in Video and Camera app header on top right. Please review. Thanks

Comment 5

[Punam Dahiya [:pdahiya]]

The proposed fix in attached PR touches code that was added as a fix of bug 1045017. Setting NI flag for yzen to provide input if this change is going to impact screen reader accessibility for status bar icons.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8504269 [details] [review]
PR with fix of bug 1081562

Delegating review to michael

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8504269 [details] [review]
PR with fix of bug 1081562

This will break status bar accessibility. The believe this should be fixed by handling the status bar visibility appropriately: by adding :not(.fullscreen-app) to lines 42 and 47 of the statusbar.css

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

In fact this should be fixed if the PR for bug 1081319 is accepted and merged in.

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Yura Zenevich [:yzen] from comment #8)
> In fact this should be fixed if the PR for bug 1081319 is accepted and
> merged in.

Thanks Yura, I have verified the patch in bug 1081319 improves the responsiveness in top half in options icon for both camera and video app. Cancelling the review for attachment 8504269 [details] [review] in favor of bug1081319 patch for fixing the issue reported in this bug.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Marking as a duplicate of bug 1081319 for now. We can reopen this if landing that one does not resolve that issue.