1081319 - [Lockscreen][Camera] Status bar icons overlap camera UI when camera app is launched from the Lockscreen with Passcode enabled.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[John Thomas [:Johnt]]

Attachment: StatusBarIcons.png

Description: The status bar icons (battery, SIM, WiFi) are visible in the Camera app when launched from the Lockscreen, and will overlap camera UI.

Note: These status bar icons are only present when the user has a Passcode enabled.  Launching the camera app from the Lockscreen (without a Passcode), or launching from the Homescreen does not display the status bar icons.

Repro Steps:
1) Update a Flame device to BuildID: 20141010000201
2) Enable Lock screen and Passcode lock in Settings > Screen lock.
3) Lock the device.
4) Press the Power Button and launch the Camera app without unlocking the phone.
5) Take a picture, then view the photo preview.

Actual:
Status Bar icons are overlapping the Camera UI
  
Expected: 
It is expected that the Status Bar icons will not overlap the Camera UI

Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro frequency: 5/5
See attached: screenshot

Repro frequency: 100%
Link to failed test case:
See attached: (screenshot, video clip, logcat,)

Comment 1

[John Thomas [:Johnt]]

This issue DOES occur in Flame 2.2
Status bar icons overlap the Camera UI

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

--------------------------------------------------------------------

This issue does NOt occur on the Flame 2.0 KK (319mb)
Result: Icons do not overlap.

Flame 2.0 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.0
Build ID: 20141010000201
Gaia: 9791940d5093c37336dcd85f7e66e9a8445a218e
Gecko: 00d3c843aeec
Version: 32.0 (2.0)
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 2

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]:

This bug was written-by-request from here: https://bugzilla.mozilla.org/show_bug.cgi?id=1079953#c8

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1045017 seems to be the cause of this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140910201328
Gaia: 6a533b800e1fa794013887761e62dd4f4d34cea1
Gecko: 65052f412002
Version: 35.0a1 (2.2) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140910205727
Gaia: 7c5014a7b040c526022126c4db09a8f065aa4275
Gecko: b2edbcf0da31
Version: 35.0a1 (2.2) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 6a533b800e1fa794013887761e62dd4f4d34cea1
Gecko: b2edbcf0da31

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: 7c5014a7b040c526022126c4db09a8f065aa4275
Gecko: 65052f412002

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/6a533b800e1fa794013887761e62dd4f4d34cea1...7c5014a7b040c526022126c4db09a8f065aa4275

Comment 4

[Joshua Mitchell (Inactive)]

Broken by Bug 1045017 - Yura can you take a look?

Comment 5

[howie [:howie]]

Triage: moving to Gaia:system since it's cause by Bug 1045017

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8504770 [details] [review]
Github pull request.

Thanks for the fix! It seems like also need to add :not(.fullscreen-layout-app) to the query selectors in each case, for consistency/future-proofing if nothing else.

Also, we are now writing tests for every single bug in the system app, including small css changes like this. If this turns out to be a 2.1 blocker, we can land this first and write the test in a follow up. If that's the case feel free to reflag me for review. For now though let's add a marionette-js test for this before landing. Ping me on IRC if you would like some help with it.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Adding whiteboard tag so we can triage on Thur.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8504770 [details] [review]
Github pull request.

Updated the visibility for fullscreen layout, added marionette tests.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8504770 [details] [review]
Github pull request.

Looks good, thanks! Left a comment about a test on github.

Comment 12

[Candice Serran (:cserran)]

regression -> blocker

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/2e38469059a9bf1017ac1ef29acac346b83d8494

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8504770 [details] [review]
Github pull request.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1045017
[User impact] if declined: Status bar visibility will be broken in fullscreen and fullscreen layout apps
[Testing completed]: Added Gij tests, passing on tree herder
[Risk to taking this patch] (and alternatives if risky): Fairly low, just a couple of CSS changes
[String changes made]: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/cedef85b023c72a01af2fc569a9f93222963e4e9

Comment 16

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Actual Results: Status bar icons not visible on camera screen or camera image preview screen while user is using lockscreen camera with passcode enabled.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022001201
Gaia: 3d9cc667f4e929861a9a77c41096bbf5a9c1bde0
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022040201
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0