1081630 - Isolate wake lock management in System from Wifi and ScreenManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Create a set of *WakeLockManager to extract mozPower.addWakeLockListener callbacks from Wifi and ScreenManager to offload code from them.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#25058

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

Alive, would you mind checking if this follows the desired system2 pattern?

Also, is there anyone you could delegate the review or co-review the finished patch? Especially guys in the systemsfe team -- I don't want to create conflict patch.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

AFAIK I am afraid on one in SystemFE had touched this code except Etienne.
Have some ideas in github.

Maybe we should have wifi_wake_lock_manager in standalone file but for now it's fine.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

I didn't follow BaseModule at the end and use the bootstrap.js.

CpuManager created too.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

\O/

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=830e0780aa07

master: https://github.com/mozilla-b2g/gaia/commit/1daf2dadcd0d554c733661a4c0be1b82001e9da0

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] shamenchens:Bug1157133-WakelockManager-v21 > mozilla-b2g:v2.1