Closed Bug 1081630 Opened 5 years ago Closed 5 years ago

Isolate wake lock management in System from Wifi and ScreenManager

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Whiteboard: [FT:System-Platform])

Attachments

(1 file, 1 obsolete file)

mozilla-b2g:master PR#25058
46 bytes, text/x-github-pull-request
alive
: review+
alive
: feedback+
Details | Review 
Create a set of *WakeLockManager to extract mozPower.addWakeLockListener callbacks from Wifi and ScreenManager to offload code from them.
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

Alive, would you mind checking if this follows the desired system2 pattern?

Also, is there anyone you could delegate the review or co-review the finished patch? Especially guys in the systemsfe team -- I don't want to create conflict patch.
Attachment #8503725 - Flags: feedback?(alive)
Whiteboard: [FT:System-Platform]
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

AFAIK I am afraid on one in SystemFE had touched this code except Etienne.
Have some ideas in github.

Maybe we should have wifi_wake_lock_manager in standalone file but for now it's fine.
Attachment #8503725 - Flags: feedback?(alive) → feedback+
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

I didn't follow BaseModule at the end and use the bootstrap.js.

CpuManager created too.
Attachment #8503725 - Flags: review?(alive)
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058

\O/
Attachment #8503725 - Flags: review?(alive) → review+
Attachment #8596449 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.