Closed
Bug 1081630
Opened 11 years ago
Closed 11 years ago
Isolate wake lock management in System from Wifi and ScreenManager
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [FT:System-Platform])
Attachments
(1 file, 1 obsolete file)
Create a set of *WakeLockManager to extract mozPower.addWakeLockListener callbacks from Wifi and ScreenManager to offload code from them.
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058
Alive, would you mind checking if this follows the desired system2 pattern?
Also, is there anyone you could delegate the review or co-review the finished patch? Especially guys in the systemsfe team -- I don't want to create conflict patch.
Attachment #8503725 -
Flags: feedback?(alive)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [FT:System-Platform]
Comment 3•11 years ago
|
||
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058
AFAIK I am afraid on one in SystemFE had touched this code except Etienne.
Have some ideas in github.
Maybe we should have wifi_wake_lock_manager in standalone file but for now it's fine.
Attachment #8503725 -
Flags: feedback?(alive) → feedback+
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058
I didn't follow BaseModule at the end and use the bootstrap.js.
CpuManager created too.
Attachment #8503725 -
Flags: review?(alive)
Comment 5•11 years ago
|
||
Comment on attachment 8503725 [details] [review]
mozilla-b2g:master PR#25058
\O/
Attachment #8503725 -
Flags: review?(alive) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=830e0780aa07
master: https://github.com/mozilla-b2g/gaia/commit/1daf2dadcd0d554c733661a4c0be1b82001e9da0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
Updated•10 years ago
|
Attachment #8596449 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•