bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove tools/reorder/, which is ancient and unused

RESOLVED FIXED in mozilla36

Status

()

Core
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla36
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
tools/reorder/ has a lot of code that appears to be be devoted to an attempt to
reorder functions in binaries to improve performance. grope.cpp has a comment
at the top:

> A program that computes a function ordering for an executable based
> on runtime profile information.
> 
> This program is directly based on work done by Roger Chickering
> <rogc@netscape.com> in
> 
>   <http://bugzilla.mozilla.org/show_bug.cgi?id=65845>
> 
> to implement Nat Friedman's <nat@nat.org> `grope',
> 
>   _GNU Rope - A Subroutine Position Optimizer_
>   <http://www.hungry.com/~shaver/grope/grope.ps>
> 
> Specifically, it implements the procedure re-ordering algorithm
> described in:
> 
>   K. Pettis and R. Hansen. ``Profile-Guided Core Position.'' In
>   _Proceedings of the Int. Conference on Programming Language Design
>   and Implementation_, pages 16-27, June 1990.

All this code was checked in by Chris Waterson in November 2001 with a commit
message that only said "First commit". I don't know if there's a bug associated
with it. It has only received trivial license and grammar-nazi changes since
then, e.g. see:
https://github.com/mozilla/gecko-dev/tree/7756488dffc09f67790b14d2141f640aefd662b7/tools/reorder

Unsurprisingly, it doesn't compile, and the whole enterprise sounds like
something that should be done as part of PGO builds or not at all.
(Assignee)

Comment 1

4 years ago
Created attachment 8503845 [details] [diff] [review]
Remove tools/reorder/, which is ancient and unused

 19 files changed, 2495 deletions(-)
Attachment #8503845 - Flags: review?(nfroyd)
(Assignee)

Updated

4 years ago
Blocks: 1080290
Comment on attachment 8503845 [details] [diff] [review]
Remove tools/reorder/, which is ancient and unused

Review of attachment 8503845 [details] [diff] [review]:
-----------------------------------------------------------------

WFM.
Attachment #8503845 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/dc83111c2f87
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.