Closed
Bug 1081792
Opened 10 years ago
Closed 10 years ago
Remove tools/page-loader/, which is ancient and unused
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
69.25 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
tools/page-loader/ is some kind of page loading test or performance thing -- I skimmed through the code and was left none the wiser, thanks to a total lack of high-level documentation. There is a README file that makes it clear that using this thing would be painful, with lots of fiddling around with Perl CPAN modules and the like. It was first landed in August 2001, and received a handful of functional updates until 2005, but nothing non-trivial (e.g. mass license changes) since then. There are no references to it from elsewhere in the tree.
Assignee | ||
Comment 1•10 years ago
|
||
dbaron, you made a two-line change to page-loader in 2005 (https://github.com/mozilla/gecko-dev/commit/ea9084367674110a96ecbdc444c749dd26a0d6a0). This makes you the only person involved with this code that I know, so you get the review :) 11 files changed, 2071 deletions(-)
Attachment #8503862 -
Flags: review?(dbaron)
Comment on attachment 8503862 [details] [diff] [review] Remove tools/page-loader/, which is ancient and unused I think this was the first performance test harness used in automation in the mozilla project's history. (Tp, also known as Tp1.) Sad to see it go, but I think only half the stuff you need was here anyway, and thus this half probably isn't useful anymore, never mind the changes that have been needed over the past 14 years to get good performance numbers.
Attachment #8503862 -
Flags: review?(dbaron) → review+
Comment 3•10 years ago
|
||
Ha, ha. I wonder if hyatt has the content pages ;-)
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb2e5db7f98
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1fb2e5db7f98
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•