1081856 - e10s: Javascript links in custom about: and chrome:// pages don't work (summary: comment #2)

Status: VERIFIED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

Attachment: WIP version of add-on with issue

STR:

1. Install attached package in Nightly
2. Open e10s window
3. Load "about:thefoxonlybetter"
4. Click on any link or button in that page

External (http) links don't work, they open a new tab as they're supposed to from the "_blank" target attribute, but that tab is blank and doesn't load the link.

Script (javascript:) links don't work, the current tab just turns blank (sometimes black) and the methods they should call don't run.

5. Load "chrome://thefoxonlybetter/content/whatsnew.xhtml" to load directly the page that about:thefoxonlybetter points to
6. Click on any link or button in that page

Everything works. Also, everything works fine in non-e10s window in about:thefoxonlybetter as well.

Comment 2

[Luís Miguel [:quicksaver] (not reading bugmail)]

Correction on comment #0, [javascript:] command links don't work in chrome pages in e10s.

Updated STR:

1. Install latest version of The Fox, Only Better (https://addons.mozilla.org/firefox/addon/the-fox-only-better/)
2. Open about:thefoxonlybetter or chrome://thefoxonlybetter/content/whatsnew.xhtml (it's the same page)
3. Try clicking on the "Addon Options" button or on the "Show this tab..." checkbox below it.
Result: The tab goes blank and in the console appears an error saying the command those link to don't exist.

I can't say if their not working at all is a regression since I originally created the bug, I may or may have not made a mistake while testing at the time. I can say for certain they're not working now, and that everything works fine in non-e10s windows. The other symptom reported in comment #0 (normal http web links) was fixed by bug 1047603.

Comment 3

[Dave Townsend [:mossop]]

Attachment: MozReview Request: bz://1081856/Mossop

/r/4003 - Bug 1081856: Allow javascript urls to load in any process.

Pull down this commit:

hg pull review -r 6c4e534d1fce84baaeff5abb08573dd1c0cb492d

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8566133 [details]
MozReview Request: bz://1081856/Mossop

https://reviewboard.mozilla.org/r/4001/#review3241

Ship It!

Comment 5

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/abec19b886f4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/abec19b886f4

Comment 7

[Luís Miguel [:quicksaver] (not reading bugmail)]

Verified fixed in latest Nightly following STR in comment #2.

Comment 9

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1081856: Allow javascript urls to load in any process.