1082002 - [10.10] White border on URL bar for popup window

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

Not sure if this is a bug or feature!

On 10.10, popup windows (eg for Persona logins) have a white border around the URL bar. It's not present on normal windows.

Comment 1

[Stephen Horlander [:shorlander]]

Doesn't look like a feature ;)

Comment 2

[:Gijs (he/him)]

This needs some CSS love; stuck this on the backlog generation.

Comment 3

[Tim Nguyen :ntim]

Changing the border-color to transparent in [0] should work. But I can't really confirm the fix (or find regressions) as I don't have an OSX machine.

[0] http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#1950

Comment 4

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #3)
> Changing the border-color to transparent in [0] should work. But I can't
> really confirm the fix (or find regressions) as I don't have an OSX machine.
> 
> [0]
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.
> css#1950

The border was deliberately made white in order to match yosemite's own native theme. We should specialcase the disabled/readonly state that it has in popups; we can't just change [0].

Comment 5

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to Tim Nguyen [:ntim] from comment #3)
> > Changing the border-color to transparent in [0] should work. But I can't
> > really confirm the fix (or find regressions) as I don't have an OSX machine.
> > 
> > [0]
> > http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.
> > css#1950
> 
> The border was deliberately made white in order to match yosemite's own
> native theme. We should specialcase the disabled/readonly state that it has
> in popups; we can't just change [0].

I think border-color: transparent automatically fits the background-color : http://jsfiddle.net/bh98w8La/1/

Comment 6

[:Gijs (he/him)]

Attachment: Screen Shot 2014-10-18 at 22.01.22.png

(In reply to Tim Nguyen [:ntim] from comment #5)
> (In reply to :Gijs Kruitbosch from comment #4)
> > (In reply to Tim Nguyen [:ntim] from comment #3)
> > > Changing the border-color to transparent in [0] should work. But I can't
> > > really confirm the fix (or find regressions) as I don't have an OSX machine.
> > > 
> > > [0]
> > > http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.
> > > css#1950
> > 
> > The border was deliberately made white in order to match yosemite's own
> > native theme. We should specialcase the disabled/readonly state that it has
> > in popups; we can't just change [0].
> 
> I think border-color: transparent automatically fits the background-color :
> http://jsfiddle.net/bh98w8La/1/

Sure, but that doesn't look right. :-)

Comment 7

[:Gijs (he/him)]

Attachment: fix urlbar to stay white,

Toolkit overrides readonly inputs to have a -moz-dialog background. This just overrides that in keeping with our pre-10.10 styles for readonly urlbar (which basically looks exactly the same on OS X as the non-read-only one). I've not updated the text color because that 'just works', and OS X isn't as themable as Windows. Let me know if you think I should change that.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8508374 [details] [diff] [review]
fix urlbar to stay white,

I don't understand why this is specific to 10.10.

Comment 9

[:Gijs (he/him)]

Comment on attachment 8508374 [details] [diff] [review]
fix urlbar to stay white,

Review of attachment 8508374 [details] [diff] [review]:
-----------------------------------------------------------------

Because we set background-image: none; on pre-10.10, the background image is a linear gradient which fully covers the original textbox background color.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8508374 [details] [diff] [review]
fix urlbar to stay white,

(In reply to :Gijs Kruitbosch from comment #9)
> on pre-10.10, the background image is
> a linear gradient which fully covers the original textbox background color.

That's dependent on -moz-mac-lion-theme. We should just set the background color unconditionally.

Also, #fff should be -moz-field instead.

If you use #urlbar[readonly], this becomes self-documenting and you can omit the comment.

Comment 11

[:Gijs (he/him)]

Attachment: fix urlbar to stay white,

Comment 12

[:Gijs (he/him)]

Comment on attachment 8508611 [details] [diff] [review]
fix urlbar to stay white,

Approval Request Comment
[Feature/regressing bug #]: yosemite
[User impact if declined]: silly looking url bar in popups on yosemite (and also 10.6, I imagine)
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: pretty much 0, small targeted CSS fix
[String/UUID change made/needed]: nope

remote:   https://hg.mozilla.org/integration/fx-team/rev/c51c71d1a378

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c51c71d1a378

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8508611 [details] [diff] [review]
fix urlbar to stay white,

Beta+
Aurora+

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55c78df1e28f
https://hg.mozilla.org/releases/mozilla-beta/rev/605c6938c9d3