Closed
Bug 1082234
Opened 10 years ago
Closed 10 years ago
JavascriptException: TypeError: values is null at: app://system.gaiamobile.org/js/telephony_settings.js line: 120
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: anshulj, Assigned: arthurcc)
References
Details
(Whiteboard: [caf priority: p2][CR 738824])
Attachments
(1 file)
|
182 bytes,
text/html
|
alive
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details |
STR
1. Load a new build on the device to make sure the default value of CLIR is set to null as per bug 1064463.
2. Call mozMobileConnection.setCallingLineIdRestriction API two or three times in a row using a test script.
Expected: The API call to setCallingLineIdRestriction pass.
Observed: A JS exception is raised instead
[Blocking Requested - why for this release]: This exception is preventing us from running a sanity test for CLIR feature to ensure the quality of this release.
This is most likely happening because as per bug 1064463 the values is not being set yet and so is null. If I open the call settings app once manually the error doesn't happen. I think we simply need a null check here.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → arthur.chen
|
|
Assignee | |
Comment 2•10 years ago
|
||
Alive, could you help review the simple patch? Thanks!
Attachment #8504576 -
Flags: review?(alive)
|
||
Updated•10 years ago
|
Component: Gaia::Settings → Gaia::System
|
||
Updated•10 years ago
|
Whiteboard: [CR 738824]
|
|
||
Updated•10 years ago
|
Whiteboard: [CR 738824] → [caf priority: p2][CR 738824]
Arthur, I tested the patch and it did solve the issue I reported. Thanks for the quick turn around.
|
||
Updated•10 years ago
|
Attachment #8504576 -
Flags: review?(alive) → review+
No longer blocks: CAF-v2.1-FC-metabug
Blocks: CAF-v2.1-CC-metabug
|
|
Assignee | |
Comment 5•10 years ago
|
||
Thanks for reviewing.
master: 6cbfaf9d652c249e1faf05d464c85525d5a38ba0
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•10 years ago
|
||
Comment on attachment 8504576 [details]
link to https://github.com/mozilla-b2g/gaia/pull/25120
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1064463
[User impact] if declined: blocks CAF tests
[Testing completed]: Manual and unit tests were completed.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A
Attachment #8504576 -
Flags: approval-gaia-v2.1?
|
||
Updated•10 years ago
|
Attachment #8504576 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
|
||
Comment 7•10 years ago
|
||
Target Milestone: --- → 2.1 S7 (24Oct)
|
||
Comment 8•10 years ago
|
||
Unable to verify this issue.
QA team does not have the resources to follow the STR in Comment 0.
QA Whiteboard: [QAnalyst-Triage?] [QAnalyst-verify-]
Flags: needinfo?(ktucker)
|
||
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] [QAnalyst-verify-] → [QAnalyst-Triage+] [QAnalyst-verify-]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•