Closed
Bug 1082452
Opened 10 years ago
Closed 10 years ago
B2G NFC: Add a parameter 'isP2P' in WriteNDEF request sending to nfcd
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [p=1])
Attachments
(2 files)
For writing NDEF it could be either writing an NDEF to a Tag or to a Remote Device. But they are not using the same physical link so nfcd could not actually know the desired end poing the app really wants. We'd like to add another parameter called 'isP2P' in WriteNDEF request to indicate this request is for P2P or for a Tag case.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → allstars.chh
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8505286 -
Flags: review?(dlee)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8505289 -
Flags: review?(dlee)
Updated•10 years ago
|
Attachment #8505286 -
Flags: review?(dlee) → review+
Comment 3•10 years ago
|
||
Comment on attachment 8505289 [details] [review] nfcd Pull Request Looks good, thanks
Attachment #8505289 -
Flags: review?(dlee) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8505286 [details] [diff] [review] Patch. Review of attachment 8505286 [details] [diff] [review]: ----------------------------------------------------------------- r? to smaug for the WebIDL change (NfcOptions.webidl).
Attachment #8505286 -
Flags: review?(bugs)
Comment 5•10 years ago
|
||
Comment on attachment 8505286 [details] [diff] [review] Patch. Should isP2P perhaps have a default value? (but fine even without it)
Attachment #8505286 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #5) > Comment on attachment 8505286 [details] [diff] [review] > Patch. > > Should isP2P perhaps have a default value? > (but fine even without it) Hi smaug, It doesn't need a default value, thanks for your review. :)
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/528b832ab478
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S7 (24Oct)
Assignee | ||
Comment 8•10 years ago
|
||
nfcd commit: https://github.com/mozilla-b2g/platform_system_nfcd/commit/72e043bc37304769b004ed960a6d16028beab5ae
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/528b832ab478
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 10•9 years ago
|
||
Parameter documented on method page: https://developer.mozilla.org/en-US/docs/Web/API/MozNFCTag/writeNDEF Also confirmed that it is mentioned on the relevant Firefox OS release notes page: https://developer.mozilla.org/en-US/Firefox_OS/Releases/2.1#Web_API_changes Could you give this a quick tech review? Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•