(App-grouping) Collapsed groups should align to the left

RESOLVED FIXED in 2.1 S7 (24Oct)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

unspecified
2.1 S7 (24Oct)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Currently collapsed groups align center - they should align to the left.
(Assignee)

Comment 1

4 years ago
Created attachment 8504780 [details] [review]
Align collapsed groups to the left
Attachment #8504780 - Flags: review?(kgrandon)
(Assignee)

Updated

4 years ago
Summary: Collapsed groups should align to the left → (App-grouping) Collapsed groups should align to the left
(Assignee)

Updated

4 years ago
Blocks: 1082629
Hey Chris - I hate to be a pain, but I think we're getting to the point where we should start landing these fixes with marionette tests where possible. Perhaps the test should do something like assert on the position of the first icon in a collapsed small group, vs a collapsed large group. Icon.getBoundingClientRect().left should take the transform effect into account.

Would you mind giving an integration test a spin before landing?
Flags: needinfo?(chrislord.net)
Attachment #8504780 - Flags: ui-review?(hnguyen)
Comment on attachment 8504780 [details] [review]
Align collapsed groups to the left

Clearing code review for now, until the question about the test is addressed.
Attachment #8504780 - Flags: review?(kgrandon)
(Assignee)

Comment 4

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #2)
> Hey Chris - I hate to be a pain, but I think we're getting to the point
> where we should start landing these fixes with marionette tests where
> possible. Perhaps the test should do something like assert on the position
> of the first icon in a collapsed small group, vs a collapsed large group.
> Icon.getBoundingClientRect().left should take the transform effect into
> account.
> 
> Would you mind giving an integration test a spin before landing?

Sure, I'll give it a go.
Flags: needinfo?(chrislord.net)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8504780 [details] [review]
Align collapsed groups to the left

Added marionette test.
Attachment #8504780 - Flags: review?(kgrandon)

Updated

4 years ago
Attachment #8504780 - Flags: ui-review?(hnguyen) → ui-review+
Attachment #8504780 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 6

4 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/1cc03651409051fc9db72c85f61cc091f9e717fd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.