Closed Bug 1082627 Opened 6 years ago Closed 6 years ago

(App-grouping) Collapsed groups should align to the left

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S7 (24Oct)

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Currently collapsed groups align center - they should align to the left.
Attachment #8504780 - Flags: review?(kgrandon)
Summary: Collapsed groups should align to the left → (App-grouping) Collapsed groups should align to the left
Blocks: 1082629
Hey Chris - I hate to be a pain, but I think we're getting to the point where we should start landing these fixes with marionette tests where possible. Perhaps the test should do something like assert on the position of the first icon in a collapsed small group, vs a collapsed large group. Icon.getBoundingClientRect().left should take the transform effect into account.

Would you mind giving an integration test a spin before landing?
Flags: needinfo?(chrislord.net)
Attachment #8504780 - Flags: ui-review?(hnguyen)
Comment on attachment 8504780 [details] [review]
Align collapsed groups to the left

Clearing code review for now, until the question about the test is addressed.
Attachment #8504780 - Flags: review?(kgrandon)
(In reply to Kevin Grandon :kgrandon from comment #2)
> Hey Chris - I hate to be a pain, but I think we're getting to the point
> where we should start landing these fixes with marionette tests where
> possible. Perhaps the test should do something like assert on the position
> of the first icon in a collapsed small group, vs a collapsed large group.
> Icon.getBoundingClientRect().left should take the transform effect into
> account.
> 
> Would you mind giving an integration test a spin before landing?

Sure, I'll give it a go.
Flags: needinfo?(chrislord.net)
Comment on attachment 8504780 [details] [review]
Align collapsed groups to the left

Added marionette test.
Attachment #8504780 - Flags: review?(kgrandon)
Attachment #8504780 - Flags: ui-review?(hnguyen) → ui-review+
Attachment #8504780 - Flags: review?(kgrandon) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/1cc03651409051fc9db72c85f61cc091f9e717fd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.