Closed Bug 1082629 Opened 10 years ago Closed 10 years ago

(App-grouping) Collapsed groups should be the same size in 4-column mode as 3-column mode

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S7 (24Oct)

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Make sure collapsed groups are always the same size
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Currently 4-column mode ends up with smaller icons when collapsing a group, but this shouldn't be the case.

        Attachment #8504856 -
        Flags: review?(kgrandon)

    
    

    
  
Patch is based on bug 1082627 to avoid rebasing.
Depends on: 1082627

    
    

    
  
Added a marionette test to verify collapsed icon size.

    
    

    
  
Comment on attachment 8504856 [details] [review]
Make sure collapsed groups are always the same size

Looks good. Thanks!

        Attachment #8504856 -
        Flags: review?(kgrandon) → review+

    
    

    
  
Merged: https://github.com/mozilla-b2g/gaia/commit/2bc67bdecbcead72e09ddf547633bef4dc711aa7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: