108264 - Getting the "autoSubscribeText" in confirm dialog, instead of newsgroup name.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2001-11-02-10, RedHat 7.2

Summary:  Getting the "autoSubscribeText" in confirm dialog, instead of 
newsgroup name.

Steps to Reproduce:

1.  Using a linux build, run 
news://news.mozilla.org/netscape.public.mozilla.performance

Expected Results:

'Would you like to subscribe to netscape.public.mozilla.performance' (or the 
truncated version, n.p.m.performance).

Actual Results:

'Would you like to subscribe to autoSubscribeText'

I don't know why we're not properly escaping whatever %s value we have here and 
filling it with the string bundle from .properties

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Just a note, this ONLY happens on my linux build, mac and win32 are peachy.

Comment 2

[(not reading, please use [e-mail] instead)]

weird that it's linux only.

Comment 3

[Håkan Waara]

Not trying to put blame on anyone but is it possible that this is a stringbundle
regression?  Just weird that it's linux only...

Comment 4

[Håkan Waara]

I'm sorry, I don't have a linux box and have no idea how this regression can be 
triggered from XP code.

Seth said he could look at this.

Comment 5

[Håkan Waara]

Tingley said to me that he also saw this (he's running Linux as well)... 

I'm starting to think this is a stringbundle bug, so reassigning to the only one
I could frequently find in the stringbundle CVS blame...but punt as needed - thanks!

Comment 6

[Alec Flett]

the problem is here:
http://lxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNNTPProtocol.cpp#1097

that NS_ConvertUCS2toUTF8 is a temporary variable, and allocates heap space to
store the string. 

You need to do something like:
NS_ConvertUTF8toUCS2 groupUCS2(group);

and then put groupUCS2.get() in the array.

Comment 7

[Håkan Waara]

Attachment: Patch -uw

Thanks for the help alecf!  This patch follows alec's advice, and as a bonus it
includes the fix for bug 109537.

Comment 8

[Håkan Waara]

Alec, can you r= this patch?  Thanks.

Comment 9

[Alec Flett]

Comment on attachment 57391 [details] [diff] [review]
Patch -uw

I'll r=alecf, but do we really need to unescape the group name?

Comment 10

[Håkan Waara]

Yes, that's the fix for bug 109537. 

Note that we only unescape the temporary |unescapedString| so that if you
subscribe to, for example, a group named "Håkan", it will display as "Håkan" and
not the escaped version of that string, which would be "H%C3A5Kan".

Comment 11

[Håkan Waara]

BTW, tingley applied this patch to his linux build and he confirmed that it
fixed the problem.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

to test, type news://news.mozilla.org/håkan in the browser.

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 14

[Alec Flett]

Comment on attachment 57677 [details] [diff] [review]
patch

sr=alecf

Comment 15

[(not reading, please use [e-mail] instead)]

fixed checked in for hwaara.

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using build 2001-11-14-08.

Thanks for fixing this!