Closed
Bug 1082757
Opened 10 years ago
Closed 10 years ago
Remove max-width & max-height from input[type=checkbox] in content.css
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 ?, firefox36 fixed, fennec35+)
RESOLVED
FIXED
Firefox 36
People
(Reporter: miketaylr, Assigned: miketaylr)
References
()
Details
Attachments
(1 file, 1 obsolete file)
838 bytes,
patch
|
miketaylr
:
review+
|
Details | Diff | Splinter Review |
(I don't know if this better fits in the Theme and Visual Design component). Originally reported in Bug 1078393, the current max-width: 14px style prevents Fennec users from being able to interact with "custom" checkbox styling techniques [1]. I wrote about this in https://miketaylr.com/posts/2014/10/max-width-in-firefox-mobile-browser-checkboxes.html. Compare Mobile Safari, Chrome Mobile, Opera Mobile, and Windows Phone with Fennec (or Firefox OS, to be filed) on the linked demo [2]. Note that desktop doesn't have max-width on it's checkboxes so people who don't test on mobile won't even know they need to manually override the ua stylesheet's max-width. The patch is simple... my only concern is there might be some internal code relying on the max-width of a checkbox being exactly 14px. Weirder things have happened. [1] http://tympanus.net/codrops/2012/09/13/button-switches-with-checkboxes-and-css3-fanciness/ [2] https://miketaylr.com/bzla/1078393-1.html
Assignee | ||
Updated•10 years ago
|
Summary: Remove max-width from input[type=checkbox] in content.css → Remove max-width & max-height from input[type=checkbox] in content.css
Assignee | ||
Updated•10 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•10 years ago
|
||
Here's a patch. I tried to run reftests locally but ran into Bug 1083279.
Assignee | ||
Updated•10 years ago
|
Component: Graphics, Panning and Zooming → General
Comment 2•10 years ago
|
||
Comment on attachment 8505605 [details] [diff] [review] 1082757.patch Review of attachment 8505605 [details] [diff] [review]: ----------------------------------------------------------------- I think this seems fine.
Updated•10 years ago
|
Attachment #8505605 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8505605 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → miket
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2316f7e0b196
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2316f7e0b196
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
tracking-fennec: ? → 35+
Now that this is fixed in 36, do we want this for Fennec 35 as well?
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•