Closed Bug 1082757 Opened 5 years ago Closed 5 years ago

Remove max-width & max-height from input[type=checkbox] in content.css

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox35 --- ?
firefox36 --- fixed
fennec 35+ ---

People

(Reporter: miketaylr, Assigned: miketaylr)

References

()

Details

Attachments

(1 file, 1 obsolete file)

(I don't know if this better fits in the Theme and Visual Design component).

Originally reported in Bug 1078393, the current max-width: 14px style prevents Fennec users from being able to interact with "custom" checkbox styling techniques [1].

I wrote about this in https://miketaylr.com/posts/2014/10/max-width-in-firefox-mobile-browser-checkboxes.html. 

Compare Mobile Safari, Chrome Mobile, Opera Mobile, and Windows Phone with Fennec (or Firefox OS, to be filed) on the linked demo [2].

Note that desktop doesn't have max-width on it's checkboxes so people who don't test on mobile won't even know they need to manually override the ua stylesheet's max-width.

The patch is simple... my only concern is there might be some internal code relying on the max-width of a checkbox being exactly 14px. Weirder things have happened.

[1] http://tympanus.net/codrops/2012/09/13/button-switches-with-checkboxes-and-css3-fanciness/
[2] https://miketaylr.com/bzla/1078393-1.html
Summary: Remove max-width from input[type=checkbox] in content.css → Remove max-width & max-height from input[type=checkbox] in content.css
tracking-fennec: --- → ?
Attached patch 1082757.patch (obsolete) — Splinter Review
Here's a patch. I tried to run reftests locally but ran into Bug 1083279.
Component: Graphics, Panning and Zooming → General
Comment on attachment 8505605 [details] [diff] [review]
1082757.patch

Review of attachment 8505605 [details] [diff] [review]:
-----------------------------------------------------------------

I think this seems fine.
Attachment #8505605 - Flags: review?(wjohnston) → review+
Attached patch 1082757.patchSplinter Review
Attachment #8505605 - Attachment is obsolete: true
Updated commit message to add "r=wesj"
Keywords: checkin-needed
Blocks: 1083536
No longer blocks: 1083536
See Also: → 1083536
Assignee: nobody → miket
https://hg.mozilla.org/mozilla-central/rev/2316f7e0b196
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
tracking-fennec: ? → 35+
Now that this is fixed in 36, do we want this for Fennec 35 as well?
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.