1082908 - [Messages] Background color of contact list should be other than white so that it differ from empty space.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[kumar rishav (:rishav_)]

Attachment: Screen Shot 2014-10-15 at 04.25.17.png

STR
*Fill the message-input upto top
*Enter the number in input box such that it show two or three contact list suggestion
*Background color of this is white which is same as empty space in right side.
* Tapping on that area may result something else (bug 1072856)

Expected
Contact list drop down should be of some different color other than white so that it will become easy to know the difference between those two area.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Hey Jenny, Fang, what do you think of this issue?

QA: can you please test in v2.1 and 2.2?

Comment 2

[Jenny Lee]

Hello!
This is something we need to fix for sure. Fang and I are working on a solution and will get back to you later. Thanks!

Comment 3

[Fang Shih [:fang]]

Attachment: Compose_SuggestionList.png

Attached the mock up for this screen. For now, We like to add a divider to separate those two areas. This divider should be the same color and thickness with the list divider, only it goes all the way to two sides. Thanks!

Comment 4

[kumar rishav (:rishav_)]

Thanks Fang
I am implementing this one assuming it's a final design/ux for now.

Comment 5

[kumar rishav (:rishav_)]

Attachment: PR

Hi Julien
Here is attached PR. Please have a look.
Thanks

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

QA: can you try in v2.0 (in addition to v2.1 I asked in comment 1). Thanks!

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8506102 [details] [review]
PR

Hey rishav,

thanks for your patch, but I think we need to be more specific about the contact-list style, because it's used at other places too.

Please ask a review when you're ready !

Comment 9

[kumar rishav (:rishav_)]

Comment on attachment 8506102 [details] [review]
PR

Hi Julien
Have a look now on this . Hope it's okay now.
Thanks

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8506102 [details] [review]
PR

r=me
thanks !

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Tested myself in v2.0, it's affected as well.

I really think it's like this since we implemented the suggestion list.

Comment 12

[kumar rishav (:rishav_)]

Hi
r=julienw . Done
Thanks

Comment 13

[Cody Roesch [:croesch]]

Tested with Full Flash on 319mb using Engineering builds

This bug repro's on Flame KK builds: Flame 2.2 KK, Flame 2.1 KK, Flame 2.0 KK, Flame 2.0 Base

Actual Results: White background for contacts drop down is the same color as blank space which is not correct.

Repro Rate: 4/4

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141020055012
Gaia: dc496d04907dd314f9736ff78bab3bd27156f79a
Gecko: f2d7d694aae5
Version: 36.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141020072210
Gaia: 6456e9d03a6f9a226818a1bccefc489a9bb7cb56
Gecko: 105d1bb4180f
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141020025114
Gaia: 63b56a7a7453726b9e12ad1afe02c68c83c5aeca
Gecko: 09b9387be5ad
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 Base
BuildID: 20140904160718
Gaia: 506da297098326c671523707caae6eaba7e718da
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 14

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/51ab1cfc1c4361c3761dd68b5c27644dcd9263a9

Comment 15

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Jenny, can you tell if you think that this should be uplifted to v2.0 or v2.1? I tried the current v2.0 and v2.1 (without the patch) and it's not that bad in my opinion.

Comment 16

[Jenny Lee]

It would be nice if we can do this for all the versions, but if there's any sort of resource limit, we can just put this in backlog, thanks!

Comment 17

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

I think we'll just let it ride the train, I don't have the time to test on v2.1 to see if it works fine, and I think Bhavana won't accept it anyway. If any parter wants it, just take it.

Comment 18

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Demo: https://wiki.mozilla.org/Gaia/SMS/Scrum/2.1S7#bug_1082908:_Background_color_of_contact_list_should_be_other_than_white_so_that_it_differ_from_empty_space

Comment 19

[Josh Cheng [:josh]]

Per comment 14. 2.2 is fixed.

@Kai-Zhen,
Could you please help to land this on 2.0M? Thanks!

Comment 20

[Kai-Zhen Li [:seinlin][:kli]]

Merge into v2.0 get conflicts. Could you rebase a version for 2.0/2.0M branch? Thanks!

Comment 21

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Uplifted patch for the v2.0 branch

Since Kumar is not available I'm providing a patch that applies to v2.0. However I'm not sure if this is enough as a lot of CSS code around the changes was also modified. Needinfo'ing Oleg to confirm that this would work fine, please don't land this in the meantime.

Comment 22

[Kai-Zhen Li [:seinlin][:kli]]

Gabriele, Thanks! Let's wait Oleg feedback.

Comment 23

[Oleg Zasypkin [:azasypkin]]

(In reply to Gabriele Svelto [:gsvelto] from comment #21)
> Created attachment 8513386 [details] [diff] [review]
> [PATCH] Uplifted patch for the v2.0 branch
> 
> Since Kumar is not available I'm providing a patch that applies to v2.0.
> However I'm not sure if this is enough as a lot of CSS code around the
> changes was also modified. Needinfo'ing Oleg to confirm that this would work
> fine, please don't land this in the meantime.

Thanks for your help, Gabriele! Looks good to me.

Comment 24

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/14f49a21922e15d87b615f6c7e99248dc7dc152b

Comment 25

[Coler]

This issue has been verified successfully on Woodduck 2.0;Flame2.2.
Reproducing rate: 0/5
See attachment: Verify_Woodduck_SMSline.mp4

Note:The reset phone function isn't working now, so we verify it by flashing ROM.

Woodduck build version:
Gaia-Rev        d742e375aca6dc1bf3a36638000ad7f5338ef457
Gecko-Rev       d049d4ef127844121c9cf14d2e8ca91fd9045fcb
Build-ID        20141126050313
Version         32.0

Flame2.2 build version:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1

Comment 26

[Coler]

Attachment: Verify_Woodduck_SMSline.MP4

Comment 27

[Coler]

(In reply to Coler from comment #25)
> This issue has been verified successfully on Woodduck 2.0;Flame2.2.
> Reproducing rate: 0/5
> See attachment: Verify_Woodduck_SMSline.mp4

> Woodduck build version:
> Gaia-Rev        d742e375aca6dc1bf3a36638000ad7f5338ef457
> Gecko-Rev       d049d4ef127844121c9cf14d2e8ca91fd9045fcb
> Build-ID        20141126050313
> Version         32.0
> 
> Flame2.2 build version:
> Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
> Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
> Build-ID        20141125040209
> Version         36.0a1

Comment 28

[Coler]

Dear all,
    Please ignore Comment 25 .Thanks.