1082997 - Build issues with skia-gpu

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The first issue is that there doesn't seem to be a way to disable it (I need to do this for now because of a lack of a 100% working GL impl).  I added a --disable-skia-gpu option.

The second issue is that gecko doesn't build when |defined(USE_SKIA) && !defined(USE_SKIA_GPU)|.  Orthogonal to a new disable-skia-gpu flag, this appears to be a supported configuration.  But luckily it looks like there's just one macro check that needs to be fixed, which I've done.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

There were a few more spots that needed to be fixed.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Add an option to explicitly disable skia-gpu and fix the build when it's disabled

Sorry to pick on you again Matt, but your review fingerprints were on this one too :).

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8505227 [details] [diff] [review]
Add an option to explicitly disable skia-gpu and fix the build when it's disabled

Review of attachment 8505227 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=31b02e393189 makes me think this patch is OK.  I don't have l3 push access anymore so have to request checkin-needed, sorry.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/751cfcb170a1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/751cfcb170a1