Closed Bug 1082997 Opened 5 years ago Closed 5 years ago

Build issues with skia-gpu

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(1 file)

The first issue is that there doesn't seem to be a way to disable it (I need to do this for now because of a lack of a 100% working GL impl).  I added a --disable-skia-gpu option.

The second issue is that gecko doesn't build when |defined(USE_SKIA) && !defined(USE_SKIA_GPU)|.  Orthogonal to a new disable-skia-gpu flag, this appears to be a supported configuration.  But luckily it looks like there's just one macro check that needs to be fixed, which I've done.
There were a few more spots that needed to be fixed.
Blocks: 849253
Sorry to pick on you again Matt, but your review fingerprints were on this one too :).
Attachment #8505227 - Flags: review?(matt.woodrow)
Comment on attachment 8505227 [details] [diff] [review]
Add an option to explicitly disable skia-gpu and fix the build when it's disabled

Review of attachment 8505227 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8505227 - Flags: review?(matt.woodrow) → review+
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=31b02e393189 makes me think this patch is OK.  I don't have l3 push access anymore so have to request checkin-needed, sorry.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/751cfcb170a1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.