1083391 - TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-panel.js.test panel contentScriptFile | Test timed out (after: Panel contentScriptFile with relative path worked)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dave Townsend [:mossop]]

This fails pretty consistently in mochitest-jetpack for some reason

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Something about how we load stuff in mochitests makes loading panel content slower. Frequently when onShow is first called the panel frame is still displaying about:blank and this causes problems in tests trying to do things to the frame's content. It strikes me that the show event shouldn't be called until the panel is both visible and its content properly loaded so this pull request makes that change.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Dave Townsend [:mossop] from comment #1)
> Created attachment 8505813 [details] [review]
> pull request
> 
> Something about how we load stuff in mochitests makes loading panel content
> slower. Frequently when onShow is first called the panel frame is still
> displaying about:blank and this causes problems in tests trying to do things
> to the frame's content. It strikes me that the show event shouldn't be
> called until the panel is both visible and its content properly loaded so
> this pull request makes that change.

With this change will the `show` event emit for every `DOMContentLoaded` event (while the panel is open)? and that appears to be a change from the previous api.

This appears to be the case to me.

Comment 3

[Dave Townsend [:mossop]]

Ah yes that wasn't intentional. I've corrected that and added a test to check it doesn't happen.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8505813 [details] [review]
pull request

looks good to me, I just mentioned some test changes that I'd like to see for r+

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8505813 [details] [review]
pull request

Updated the pull request from the comments.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8505813 [details] [review]
pull request

Thanks!

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ea2f56bdd45b54e4ec59bfc97275b9d4added77f
Bug 1083391: Only send panel show/hide events after the panel's document is ready. r=erikvold

Comment 8

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/573f42076ad7

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/573f42076ad7