1083798 - [Loop] The Shared URL doesn't show the friendly name of the contact the URL was shared

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

STR:
1. User A calls to a user B no registered in Loop (included in his Address Book with "Noloop" name) 
2. As User B is not registered in Loop application, the fallback mechanism to share a Loop URL with him is offered to User A
3. User A sends that URL to user B via SMS or via e-mail
4. User A edits user B (included in his Address Book) and user A deletes name to ser B.

Expected Result:
In the "Shared URL" tab of Device A, a new entry should appear including some information about B contact and the shared URL sent to him. 

Current Result:
Any information about contact B does not appear in the "Shared URL" entry just the identity with we have tried to make the Loop call.

Comment 1

[Loli (:lolimartinezcr)]

(In reply to Loli (:lolimartinezcr) from comment #0)

I rewrite better steps:



> STR:
> 1. User A calls to a user B no registered in Loop (included in his Address
> Book with "Noloop" name) 
> 2. As User B is not registered in Loop application, the fallback mechanism
> to share a Loop URL with him is offered to User A
> 3. User A sends that URL to user B via SMS or via e-mail
  4. User A taps in "home" button (Loop application is in background).
  5. User A taps in "contact" application
> 6. User A edits user B (included in his Address Book) and user A deletes
> name to ser B.
> 7. User A taps in "home" button (contact apllication is in background)
  8. User A taps in "Loop" application

> Expected Result:
> In the "Shared URL" tab of Device A, a new entry should appear including
> some information about B contact and the shared URL sent to him. 


> 
> Current Result:
> Any information about contact B does not appear *inmediately* in the "Shared URL" entry
> just the identity with we have tried to make the Loop call.

User A can see information about contact B In the "Shared URL" tab when closes Loop completely and after opens Loop application again.

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks Fernando!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8506175 [details]
Github pull request

r=me with the comments addressed

Comment 4

[Cristian Rodriguez (:crdlc)]

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6284344b4b041cabeb709b8e040b8c097bdd8ea0

Comment 5

[Loli (:lolimartinezcr)]

Bug created in:

fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965

Comment 6

[Maria Angeles Oteo (:oteo)]

Testing the patch in master is working perfectly (I have checked that removing the name of the contact the identity is shown instead) in the Shared URLs tab and also in the call log for direct Loop calls and also incoming calls that come from a shared URL. 

Although the bug is not blocking, it works fine and blocks bug 1084309 that imho it's blocking and should be uplifted to 1.1 branch.

Cristian, go ahead with the uplift of this bug to 1.1 branch, please

Comment 7

[Cristian Rodriguez (:crdlc)]

in 1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/268bafd8db813ab4b574192060a6195920578769

Comment 8

[Javier de Prado]

Pending to be verified on production environment. (5th November)

Comment 9

[Loli (:lolimartinezcr)]

Tested, once user A deletes name to user B and user A can see information about contact B In the "Shared URL" tab (in my case phone number is showed)

Flame
eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , 2e7c3c2