[Loop] During an audio/video call and share UI I can't see the ID (email/phone) of the contact

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: lolimartinezcr, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][Test-Run1][loop in 1.1][tef-triage][loop approved for 1.1])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8506798 [details]
2014-10-17-11-41-55.png

Device: Fire
Version: 2168965

Prerequisites: Contact saved only with phone number in Device A

STRs:
1. Device A makes a Loop audio/video call to Device B (contact saved only with phone number).
2. Device B answer the audio/video call.

Actual result:
During an audio/video call I can't see the ID (email/phone) of the contact (See attached image)

Expected result:
During an audio/video call I can see the ID (email/phone) of the contact
(Reporter)

Updated

4 years ago
Blocks: 1036490
Whiteboard: [mobile app][Test-Run1]
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Reporter)

Comment 1

4 years ago
(In reply to Loli (:lolimartinezcr) from comment #0)
> Created attachment 8506798 [details]
> 2014-10-17-11-41-55.png
> 
> Device: Fire
> Version: 2168965
> 
> Prerequisites: Contact saved only with phone number in Device A
> 
> STRs:
> 1. Device A makes a Loop audio/video call to Device B (contact saved only
> with phone number).
> 2. Device B answer the audio/video call.
> 
> Actual result:
> During an audio/video call I can't see the ID (email/phone) of the contact
> (See attached image)
> 
> Expected result:
> During an audio/video call I can see the ID (email/phone) of the contact

I add:

- Bug created in:

fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965

- In step 1 Device A makes a Loop audio/video call to Device B *since call log*
(Assignee)

Comment 2

4 years ago
Created attachment 8506814 [details]
Github pull request
Attachment #8506814 - Flags: review?(ferjmoreno)
(Assignee)

Updated

4 years ago
Depends on: 1083798
(Assignee)

Comment 3

4 years ago
I have added the dependency just in case it ends in 1.1
(Assignee)

Comment 4

4 years ago
We have the same issue in the share UI and I fixed this here as well

https://github.com/mozilla-b2g/firefoxos-loop-client/pull/213/files#diff-bae951e6c6b471772863c84f9a132b24L207
(Assignee)

Updated

4 years ago
Summary: [Loop] During an audio/video call I can't see the ID (email/phone) of the contact → [Loop] During an audio/video call and share UI I can't see the ID (email/phone) of the contact
Attachment #8506814 - Flags: review?(ferjmoreno) → review+
Whiteboard: [mobile app][Test-Run1] → [mobile app][Test-Run1][patch available]
(Assignee)

Comment 5

4 years ago
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/398073310a502ac05e9fa40e220549e38b44d340
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app][Test-Run1][patch available] → [mobile app][Test-Run1][loop not in 1.1]
Severity: normal → major
Whiteboard: [mobile app][Test-Run1][loop not in 1.1] → [mobile app][Test-Run1][loop not in 1.1][tef-triage]
Cristian, can you uplift this patch to 1.1 branch? Thanks a lot!
Flags: needinfo?(crdlc)
Whiteboard: [mobile app][Test-Run1][loop not in 1.1][tef-triage] → [mobile app][Test-Run1][loop not in 1.1][tef-triage][loop approved for 1.1]
(Assignee)

Comment 7

4 years ago
in 1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/e58c7a56cbc98678c4c55f92cd1c7e0dbba68cbc
Flags: needinfo?(crdlc)
Whiteboard: [mobile app][Test-Run1][loop not in 1.1][tef-triage][loop approved for 1.1] → [mobile app][Test-Run1][loop in 1.1][tef-triage][loop approved for 1.1]
(Reporter)

Comment 8

4 years ago
Tested 
Flame
Eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , aba155c
(Reporter)

Comment 9

4 years ago
(In reply to Loli (:lolimartinezcr) from comment #8)
> Tested and working
> Flame
> Eng
> v2.0
> Gecko-dde9d61
> Gaia-7b8df99
> Loop version: 1.1 , aba155c
(Reporter)

Updated

4 years ago
Status: RESOLVED → VERIFIED
Blocks: 1010324
You need to log in before you can comment on or make changes to this bug.