1084041 - Delete files from sdcard after successful FOTA

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[David Flanagan [:djf]]

One of our partners points out: "I find that in firefox os, after fota update finished, the update package is not deleted after reboot. As the package is download to internal sdcard, so it would occupy memory, does not look good to the consumer."

Dave Hylands confirms: "I don' think that we have any code to  do anything with the update.zip, nor the update.mar after a successful fota. So yeah - I think its worth filing a bug"

Comment 1

[David Flanagan [:djf]]

Alexandre,

Dave suggests that you might be a good person to take this bug. I'm setting needinfo to let you know about it.

Comment 2

[:gerard-majax]

I think that it makes sense, I'll take this but I'm not sure I can focus on it very soon because we still have some Settings API strange issues to address :(.

So, if it's an urgent matter, someone could still steal it. Given that it's not yet marked as blocking 2.1 or 2.2, I get that we have some spare time for it.

Comment 3

[Francis Lee [:frlee]]

[Blocking Requested - why for this release]:

partner does have concern on this issue, raise it for 2.1? for triage purpose.

Comment 4

[Gregor Wagner [:gwagner]]

Too late to block on this. We will fix on master and uplift based on risk.

Comment 5

[:gerard-majax]

Flame Kitkat recovery is not working properly, the one from v188 images just spits errors because it cannot find /sdcard.

Comment 6

[:gerard-majax]

So we have those files that are staying:
> /storage/sdcard0/updates/:
> drwxrwxr-x root     sdcard_rw          2014-06-06 21:41 0
> drwxrwxr-x root     sdcard_rw          2014-10-28 13:30 fota
> 
> /storage/sdcard0/updates//0:
> 
> /storage/sdcard0/updates//fota:
> -rwxrwxr-x root     sdcard_rw        0 2014-10-28 13:30 precomplete
> -rwxrwxr-x root     sdcard_rw 62612319 2014-10-28 13:30 update.zip

Comment 7

[:gerard-majax]

And we also have:
> /data/local/b2g-updates:
> -rw-rw-rw- root     root     62520942 2014-10-28 14:28 fota-flame-update.mar

Comment 8

[Francis Lee [:frlee]]

hi Wesly,

would you please check this issue mentioned in comment5?

Comment 9

[Wesly Huang (EPM)]

looks current fixing progress is blocked by 1067055 (on Viral now) and I will discuss w/ him about it.

Comment 10

[:gerard-majax]

Attachment: B2G PR

That's a first try, but until recovery is fixed on KK for Flame, I cannot make sure anything will work as expected.

Meanwhile, there's a couple of points to address:
 - the MAR files includes the name of the device. Maybe we can just trash /data/local/b2g-updates/ ?
 - I need to make sure we have a reliable way to find the sdcard mount point

Comment 11

[Francis Lee [:frlee]]

hi Wesly,

any update for recovery mode?

Comment 12

[Wesly Huang (EPM)]

Seems this is not for Viral now and I would like to have T2M to look into if can repro. in v188 base image.

Hi Alexandre: 

Would you help put more about your comment#5 above? Did you based on v188 "base image" (no shallow flash Gaia/Gecko) to perform phone reset then get such error? Or other STR?

Comment 13

[:gerard-majax]

(In reply to Wesly Huang from comment #12)
> Seems this is not for Viral now and I would like to have T2M to look into if
> can repro. in v188 base image.
> 
> Hi Alexandre: 
> 
> Would you help put more about your comment#5 above? Did you based on v188
> "base image" (no shallow flash Gaia/Gecko) to perform phone reset then get
> such error? Or other STR?

That's unrelated to Gecko/Gaia flashing: the recovery partition provided with v188 base image spits all those errors on boot of the recovery system.

Given the kind of patch we are talking about, I just cannot rely on unreliable recovery.

Comment 14

[Wesly Huang (EPM)]

Hi Alexandre:

As the offline discussion before we believe recovery mode should still work & SDcard can be mounted even you flashed own built boot/userdata/system images (as long as recovery image is unchanged). But per vendor's feedback this might not be true, and recommended to get recovery.fstab from v188 base image to your device. Is it work?

Comment 15

[:gerard-majax]

(In reply to Wesly Huang from comment #14)
> Hi Alexandre:
> 
> As the offline discussion before we believe recovery mode should still work
> & SDcard can be mounted even you flashed own built boot/userdata/system
> images (as long as recovery image is unchanged). But per vendor's feedback
> this might not be true, and recommended to get recovery.fstab from v188 base
> image to your device. Is it work?

I don't know. The real issue here is that we cannot build and flash a working recovery ouselves. Please consider this the real priority, everything else is noise and workaround.

Comment 16

[Wesly Huang (EPM)]

I think Viral and vendor had just clarified yesterday about the issue (dialer crash) which blocks pvt build w/ latest v188 code, so should be soon can have our own build work to proceed, right?

Comment 17

[:gerard-majax]

(In reply to Wesly Huang from comment #16)
> I think Viral and vendor had just clarified yesterday about the issue
> (dialer crash) which blocks pvt build w/ latest v188 code, so should be soon
> can have our own build work to proceed, right?

Is it just me or this is just totally unrelated ? I'm asking that we (me) can build and flash our own recovery partition, from our source tree.

We can do this currently but the resulting recovery DOES NOT work. That's documented in bug 1067005: everything is blue.

Comment 18

[Wesly Huang (EPM)]

I mean previously we know there is some code not up to date and will cause problem for pvt build (ex: dialer crash issue), and now get clarified and sync latest code in our side. If recovery issue is also related to old code issue (which is of course my guess) then there could be a chance to proceed now. Anyway I will talk w/ Viral on Monday about 1067005.

Comment 19

[:gerard-majax]

Ok so we now have a recovery that works, I'll be able soon to resume work on this.

Comment 20

[:gerard-majax]

So, it looks like the error I experienced on bug 1067005 comment 18 was because of bug 1051191

Comment 21

[:gerard-majax]

Attachment: PR for gonk-misc

Comment 22

[:gerard-majax]

Attachment: B2G PR

Comment 23

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8540746 [details] [review]
PR for gonk-misc

LGTM.

Comment 24

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8540749 [details] [review]
B2G PR

I've left a small nit in the PR but it's looking good anyway.

Comment 25

[Michael Wu [:mwu]]

Comment on attachment 8540746 [details] [review]
PR for gonk-misc

Gabriele's review on this is sufficient.

Comment 26

[:gerard-majax]

https://github.com/mozilla-b2g/gonk-misc/commit/ce7b7cbc26a3e23e7dd72a17c0d0d755cb5d5423
https://github.com/mozilla-b2g/B2G/commit/5ea5b03d0426fb1560e20c74b82ad2f03b1dd792