Closed Bug 1084088 Opened 9 years ago Closed 9 years ago

Update Sync tabs panel's list item colors

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
x86
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 fixed, firefox36 fixed, fennec35+)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
fennec 35+ ---

People

(Reporter: antlam, Assigned: nalexander, Mentored)

References

Details

(Whiteboard: [lang=java])

Attachments

(3 files)

Screenshot_2014-10-16-15-03-40.png
145.76 KB, image/png
Details
Use regular home tab background color in Synced Tabs client.
1.09 KB, patch
nalexander
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Synced.Tabs.Client.Colors.png
138.17 KB, image/png
antlam
: review+
Details 
Noticed that the color of the device list item (expandable) was #F5F7F9. Could we update this to #F5F5F5 to be consistent with the other panels?
We should use the same color value that lucasr used in bug 1058660.

Although, synced tabs came along after the new toolbar landed, color consistency is part of this effort.
Blocks: new-toolbar-v1
(In reply to :Margaret Leibovic from comment #1)
> We should use the same color value that lucasr used in bug 1058660.
> 
> Although, synced tabs came along after the new toolbar landed, color
> consistency is part of this effort.

My thoughts exactly. #F5F5F5 is the color that we're using for those "headers" in that bug :)
NI-ing Nick to get this on his radar :)
Flags: needinfo?(nalexander)
This shouldn't be too hard, I can mentor this if nalexander doesn't have time to work on it.
Mentor: margaret.leibovic
Whiteboard: [lang=java]
tracking-fennec: --- → ?
Blocks: remotetabsv2
Flags: needinfo?(nalexander)
Assignee: nobody → nalexander
tracking-fennec: ? → 35+
antlam: here are the new colors.  Verified using Developer Tools' eyedropper.
Attachment #8517003 - Flags: review?(alam)
Comment on attachment 8517003 [details]
Synced.Tabs.Client.Colors.png

Nice work - Thanks.
Attachment #8517003 - Flags: review?(alam) → review+
Comment on attachment 8516998 [details] [diff] [review]
Use regular home tab background color in Synced Tabs client.

Review of attachment 8516998 [details] [diff] [review]:
-----------------------------------------------------------------

This is trivial; marking as r=antlam.
Attachment #8516998 - Flags: review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3c0e1e8fd446
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Since this is tracked for Fennec 35, do we want this to uplift?
status-firefox35: --- → ?
status-firefox36: --- → fixed
Flags: qe-verify-
Comment on attachment 8516998 [details] [diff] [review]
Use regular home tab background color in Synced Tabs client.

Approval Request Comment
[Feature/regressing bug #]: none.

[User impact if declined]: visual inconsistency.

[Describe test coverage new/current, TBPL]: TBPL, local testing.

[Risks and why]: none.

[String/UUID change made/needed]: none.
Attachment #8516998 - Flags: approval-mozilla-aurora?
Attachment #8516998 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.