1084088 - Update Sync tabs panel's list item colors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: Screenshot_2014-10-16-15-03-40.png

Noticed that the color of the device list item (expandable) was #F5F7F9. Could we update this to #F5F5F5 to be consistent with the other panels?

Comment 1

[:Margaret Leibovic]

We should use the same color value that lucasr used in bug 1058660.

Although, synced tabs came along after the new toolbar landed, color consistency is part of this effort.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #1)
> We should use the same color value that lucasr used in bug 1058660.
> 
> Although, synced tabs came along after the new toolbar landed, color
> consistency is part of this effort.

My thoughts exactly. #F5F5F5 is the color that we're using for those "headers" in that bug :)

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

NI-ing Nick to get this on his radar :)

Comment 4

[:Margaret Leibovic]

This shouldn't be too hard, I can mentor this if nalexander doesn't have time to work on it.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Use regular home tab background color in Synced Tabs client.

Screenshot to follow.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Synced.Tabs.Client.Colors.png

antlam: here are the new colors.  Verified using Developer Tools' eyedropper.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8517003 [details]
Synced.Tabs.Client.Colors.png

Nice work - Thanks.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8516998 [details] [diff] [review]
Use regular home tab background color in Synced Tabs client.

Review of attachment 8516998 [details] [diff] [review]:
-----------------------------------------------------------------

This is trivial; marking as r=antlam.

Comment 9

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/3c0e1e8fd446

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c0e1e8fd446

Comment 11

[u279076]

Since this is tracked for Fennec 35, do we want this to uplift?

Comment 12

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8516998 [details] [diff] [review]
Use regular home tab background color in Synced Tabs client.

Approval Request Comment
[Feature/regressing bug #]: none.

[User impact if declined]: visual inconsistency.

[Describe test coverage new/current, TBPL]: TBPL, local testing.

[Risks and why]: none.

[String/UUID change made/needed]: none.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e62482d78bf0