1084092 - Clean up some of the changes from bug 1013989

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

> # LOCALIZATION NOTE(quit-button.tooltiptext.mac): %1$S is the brand name (e.g. Firefox),
> # %2$S is the keyboard shortcut
quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> # LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
	
This is the wrong entity name.
> quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> # LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
> # approval before you change it.
> loop-call-button3.label = Hello
	
The tooltiptext entity name should have been updated to remain consistent with the label entity name per https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Updating_Entity_Names

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8506463 [details] [diff] [review]
Patch

Review of attachment 8506463 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for 36 only due to string freeze

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Landed as:
https://hg.mozilla.org/integration/fx-team/rev/d65025901ac3

Then backed out and relanded for a better commit message:
https://hg.mozilla.org/integration/fx-team/rev/e9e53dd43176 (backout)
https://hg.mozilla.org/integration/fx-team/rev/1ff43d819863 (better commit message)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ff43d819863

Comment 5

[u279076]

(In reply to Carsten Book [:Tomcat] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/1ff43d819863

This is mozilla36.