Closed Bug 1084092 Opened 5 years ago Closed 5 years ago

Clean up some of the changes from bug 1013989

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.1
Tracking Status
firefox36 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

> # LOCALIZATION NOTE(quit-button.tooltiptext.mac): %1$S is the brand name (e.g. Firefox),
> # %2$S is the keyboard shortcut
quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> # LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
	
This is the wrong entity name.
> quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> # LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
> # approval before you change it.
> loop-call-button3.label = Hello
	
The tooltiptext entity name should have been updated to remain consistent with the label entity name per https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Updating_Entity_Names
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch PatchSplinter Review
Attachment #8506463 - Flags: review?(MattN+bmo)
Comment on attachment 8506463 [details] [diff] [review]
Patch

Review of attachment 8506463 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for 36 only due to string freeze
Attachment #8506463 - Flags: review?(MattN+bmo) → review+
Landed as:
https://hg.mozilla.org/integration/fx-team/rev/d65025901ac3

Then backed out and relanded for a better commit message:
https://hg.mozilla.org/integration/fx-team/rev/e9e53dd43176 (backout)
https://hg.mozilla.org/integration/fx-team/rev/1ff43d819863 (better commit message)
Whiteboard: [fixed in fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ff43d819863
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
(In reply to Carsten Book [:Tomcat] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/1ff43d819863

This is mozilla36.
Target Milestone: mozilla35 → mozilla36
You need to log in before you can comment on or make changes to this bug.