1013989 - Change the name for the Loop button for Firefox Beta 34

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

This gets shown in the Customize UI and in the App/Hamburger menu.

Currently the name is blank, but it needs to be decided on before we ship.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Presumably, this is in part a UX question, and may or may not want to be directly related to the project name.  Adding :darrin to the CC for his input.

Comment 2

[Maire Reavy [:mreavy]]

We'd like this very soon, but we don't need it for Fx 32.

Comment 3

[Mark Banner (:standard8)]

Just a thought, this doesn't necessarily have to be a 'product' name, just something short & descriptive enough that users will understand it when they see it in the application menu, or the main customise screen.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Right, something like "Make a call"/"Video calling"/"Video phone"/"Internet phone"/"Internet calling"/"Interactive messaging"  would work. Similarly, we debated having a proper noun for the new Firefox menu but ended up going with "Open menu" for the tooltip.

Comment 5

[Mark Banner (:standard8)]

Thanks for the hint, poking back at RT/Darrin for comment/decision.

Comment 6

[Romain Testard [:RT]]

Arcadio, any views?

Comment 8

[Mark Banner (:standard8)]

Shell, I disagree that this is a duplicate - this is for the button name in the Firefox customizations which may or may not be the same as the branded name (as suggested in comment 4).

This bug also needs to implement it once the decision is made. We're still waiting input from Arcadio.

Comment 9

[Romain Testard [:RT]]

Arcadio, the decision has been made now so please advise on the exact button name to be used and when is the earliest we can land this.

Comment 10

[alainez]

Romain, 

The app icon should read Firefox Hello. I heard there's a device where I can see the treatment, I'm going to try to find that. 

In the meantime, can we attach a mock-up to this bug for review?

Thanks. 
arcadio

Comment 11

[Mark Banner (:standard8)]

Attachment: Customise Menu

(In reply to alainez from comment #10)
> The app icon should read Firefox Hello. I heard there's a device where I can
> see the treatment, I'm going to try to find that. 
> 
> In the meantime, can we attach a mock-up to this bug for review?

Arcadio, I'm confused, do you really mean the app icon? This bug is discussing the icon name within the application menu within Firefox Desktop.

Here's the screenshot of one place it would be shown (also in the customize toolbars screens).

See also comment 4 for more info.

Comment 12

[:shell escalante]

Bug was to implement the name once decided.  Will update tomorrow when the name should be validated.

Comment 13

[:shell escalante]

for this bug - we want to use these icons instead of the phone place holder: https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#toolbar

if there's an image where the name appears below the icon - it should say Hello - similar to other icons in that area which use the application name (not FireFox Hello)

Comment 14

[Romain Testard [:RT]]

(In reply to sescalante from comment #13)
> for this bug - we want to use these icons instead of the phone place holder:
> https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#toolbar
> 
> if there's an image where the name appears below the icon - it should say
> Hello - similar to other icons in that area which use the application name
> (not FireFox Hello)

As per discussions with Arcadio, we should not use the "Hello" name until we land on Beta.
Please carry on using "Invite someone to talk" until we get to Beta.

Comment 15

[Maire Reavy [:mreavy]]

Mark -- We know the name, but we don't want to use it until Beta.  Should we do this work at the end of the Fx35 time frame and uplift it into the first Beta 34?

Comment 16

[Maire Reavy [:mreavy]]

Making this a P2 to separate it from the other P1 work that we want to do during the Nightly cycle.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Will the name still be "Firefox Hello" or "Hello" in builds with non-English locales? I am assuming so, but I just wanted to make sure the decision was explicit, and also so we can let localizers know not to change this string.

Comment 18

[Maire Reavy [:mreavy]]

(In reply to [Away for most of July] (please needinfo? me) Jared Wein [:jaws] from comment #17)
> Will the name still be "Firefox Hello" or "Hello" in builds with non-English
> locales? I am assuming so, but I just wanted to make sure the decision was
> explicit, and also so we can let localizers know not to change this string.

I'm not 100% sure, so let's check with Arcadio in Marketing.

Arcadio -- Can you answer Jared's question: Will the name still be "Firefox Hello" or "Hello" in builds with non-English locales?  Thanks.

Comment 19

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #15)
> Mark -- We know the name, but we don't want to use it until Beta.  Should we
> do this work at the end of the Fx35 time frame and uplift it into the first
> Beta 34?

We should do the work to prepare for the name change in 34. This means having new strings ready, and having a placeholder for "Hello" in the meantime.

I don't think any of the existing strings are affected by it.

However, I would point out that I don't think comment 11 has been answered, and that still leaves the question of:

For Firefox Desktop, in the Application menu, for the current phone icon (to be replaced in a separate bug), do we want that text to be "Hello", "Firefox Hello" or something like "Make a call"/"Video calling"/"Video phone"/"Internet phone"/"Internet calling"/"Interactive messaging" as previously suggested.

See comment 3 and 4 for more information.

Comment 20

[Romain Testard [:RT]]

> However, I would point out that I don't think comment 11 has been answered,
> and that still leaves the question of:
> 
> For Firefox Desktop, in the Application menu, for the current phone icon (to
> be replaced in a separate bug), do we want that text to be "Hello", "Firefox
> Hello" or something like "Make a call"/"Video calling"/"Video
> phone"/"Internet phone"/"Internet calling"/"Interactive messaging" as
> previously suggested.
> 
> See comment 3 and 4 for more information.

I answered it in comment 14: 
"As per discussions with Arcadio, we should not use the "Hello" name until we land on Beta.
Please carry on using "Invite someone to talk" until we get to Beta."

Comment 21

[Jared Wein [:jaws] (please needinfo? me)]

Romain, are you addressing comment 18? The answer must be that we will use "Hello" in all locales because we cannot lift a string to Beta that needs to be translated.

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

:jaws that would seem to assume that we want to localize the name itself at all.  Do we?

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

That was my question in comment 17.

Comment 24

[Dan Mosedale (:dmosedale, :dmose)]

Indeed it was; I'll wait on that to be answered.  :-)

Comment 25

[Romain Testard [:RT]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #17)
> Will the name still be "Firefox Hello" or "Hello" in builds with non-English
> locales? I am assuming so, but I just wanted to make sure the decision was
> explicit, and also so we can let localizers know not to change this string.

I am pretty sure this is "Firefox Hello" for all locales. Arcadio, can you confirm?

Comment 26

[alainez]

Hi. 

Yes. It's Firefox Hello in all locales. 

Thank you!!

arcadio

Comment 27

[:shell escalante]

Arcadio - just hitting you up for objections to just "Hello" on the hamburger menu.  logic is since they are in the menu - likely don't need to see "Firefox Hello".

Comment 28

[Mark Banner (:standard8)]

(Commenting on User Story)
> This gets shown in the Customize UI and in the App/Hamburger menu.
> 
> Currently the name is blank, but it needs to be changed to "Hello" before we
> ship.

The name isn't currently blank, its "Invite someone to talk". This also gets shown on hover.

Comment 29

[Marco Mucci [:MarcoM]]

Added to IT 36.1

Comment 30

[alainez]

Hi if the question is should the name of the Icon in the hamburger icon be just: Hello

I'm good with this since the it's already in Firefox.

Comment 31

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1 for fx-team: change the label of the Loop button to Hello

Comment 32

[Matthew N. [:MattN]]

Comment on attachment 8505568 [details] [diff] [review]
Patch v1 for fx-team: change the label of the Loop button to Hello

Review of attachment 8505568 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties
@@ -96,5 @@
>  # LOCALIZATION NOTE(quit-button.tooltiptext.mac): %1$S is the brand name (e.g. Firefox),
>  # %2$S is the keyboard shortcut
>  quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> -loop-call-button2.label = Start a conversation

For 36 I think you should still use a string as I don't think we hard-code strings normally. There should be a localization note stating that it's a product name and changes need approval. For branches with string freeze I think this patch is fine.

Comment 33

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2 for fx-team: change the label of the Loop button to Hello

Comment 34

[Matthew N. [:MattN]]

Comment on attachment 8505612 [details] [diff] [review]
Patch v2 for fx-team: change the label of the Loop button to Hello

Review of attachment 8505612 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with loop-call-button3.label

::: browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties
@@ +98,5 @@
>  quit-button.tooltiptext.mac = Quit %1$S (%2$S)
>  
> +# LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
> +# approval before you change it.
> +loop-call-button2.label2 = Hello

ITYM loop-call-button3.label (update the comment too)

Comment 35

[Matthew N. [:MattN]]

Ideally this would use clientShortname2 from loop.properties but that include "Firefox" and arguably should have been the long version with the "short" version being just "Hello".

Comment 36

[Mike de Boer [:mikedeboer]]

(In reply to Matthew N. [:MattN] (behind on reviews - focused on Loop) from comment #34)
> ITYM loop-call-button3.label (update the comment too)

Hrm. Inconsistent string versioning FTW.

Comment 37

[Mike de Boer [:mikedeboer]]

Attachment: Patch v3 for fx-team: change the label of the Loop button to Hello

Comments addressed, carrying over r=MattN.

Setting checkin-needed for this patch, because the tree is closed atm.

Comment 38

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/fx-team/rev/cbf96909b5bc

Comment 39

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1 for aurora/beta: change the label of the Loop button to Hello

Comment 40

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbf96909b5bc

Comment 41

[Matthew N. [:MattN]]

Comment on attachment 8506069 [details] [diff] [review]
Patch v1 for aurora/beta: change the label of the Loop button to Hello

Review of attachment 8506069 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with customizableWidgets.properties reverted

::: browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties
@@ -99,5 @@
>  
>  panic-button.label = Forget
>  panic-button.tooltiptext = Forget about some browsing history
>  
> -loop-call-button.label = Invite someone to talk

Don't delete the string for Aurora/Beta. Leave it unused. Deleting strings is still a problem for string freeze last I checked. By leaving it we won't break string freeze.

Comment 42

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2 for aurora/beta: change the label of the Loop button to Hello

Updated patch ready for landing. Carrying over r=MattN.

Comment 43

[Randell Jesup [:jesup] (needinfo me)]

Fixed on m-c

Comment 44

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8506379 [details] [diff] [review]
Patch v2 for aurora/beta: change the label of the Loop button to Hello

Review of attachment 8506379 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizableWidgets.jsm
@@ +907,5 @@
>    CustomizableWidgets.push({
>      id: "loop-call-button",
>      type: "custom",
>      // XXX Bug 1013989 will provide a label for the button
> +    label: "Hello",

The above comment should be deleted.

Comment 45

[Maire Reavy [:mreavy]]

Pauly -- Can you test this with tomorrow's Nightly?  We want to get this into Beta2.

It's just the name change.  If you drag the Hello button from the toolbar in Nightly to the customize menu, you should see it has "Hello" under the icon.  Thanks.

Comment 46

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:

This changes the icon name under the icon to "Hello"

Comment 47

[Maire Reavy [:mreavy]]

Comment on attachment 8506379 [details] [diff] [review]
Patch v2 for aurora/beta: change the label of the Loop button to Hello

Approval Request Comment
[Feature/regressing bug #]: "Hello" name
[User impact if declined]: Name of icon will not appear below icon
[Describe test coverage new/current, TBPL]:landed on m-c, manually tested
[Risks and why]: Without this the "Hello" icon in the palette won't have the official name
[String/UUID change made/needed]: No strings

Comment 48

[Paul Silaghi, QA [:pauly]]

The icon is now called 'Hello'.
Verified fixed FF 36.0a1 (2014-10-17) Win 7, Ubuntu 14.04, OS X 10.9.5

Comment 49

[Eduardo Trápani]

The entity mentioned in the localization note does not match the entity. I looks outdated. So it's not clear if localizers need to ask approval before changing it or not.

# LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
# approval before you change it.
loop-call-button3.label = Hello

Comment 50

[Mike de Boer [:mikedeboer]]

Eduardo, you're right! I forgot to update the comment :(

Fixed: https://hg.mozilla.org/integration/fx-team/rev/75c3e79b9c7c

Comment 51

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8506379 [details] [diff] [review]
Patch v2 for aurora/beta: change the label of the Loop button to Hello

Thank you for not breaking string freeze. Beta+ and Aurora+

Comment 52

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/75c3e79b9c7c

Comment 53

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Eduardo Trápani from comment #49)
> The entity mentioned in the localization note does not match the entity. I
> looks outdated. So it's not clear if localizers need to ask approval before
> changing it or not.
> 
> # LOCALIZATION NOTE(loop-call-button2.label2): This is a brand name, request
> # approval before you change it.
> loop-call-button3.label = Hello

FYI, this was being handled by bug 1084092.

Comment 54

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d90f44e6585

Comment 55

[Randell Jesup [:jesup] (needinfo me)]

Tested and good on tbpl Aurora build

Comment 56

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2edc9ed56fa4

Comment 57

[u279076]

I'm deprioritizing further QE testing of this bug as it's been verified in Nightly and is a low risk change.