Closed
Bug 1084233
Opened 10 years ago
Closed 9 years ago
Add marionette test for icc.unlockCardLock and icc.getCardLock
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S1 (5dec)
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(4 files, 9 obsolete files)
2.91 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
7.81 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
13.58 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
5.06 KB,
patch
|
Details | Diff | Splinter Review |
Now we only have test cases for icc.setCardLock and icc.getCardLockRetryCount [1], this bug is filed for icc.unlockCardLock and icc.getCardLock. It always good to have more tests. But we need emulator support facility lock first. [1] http://dxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/test_icc_card_lock.js
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → echen
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8510996 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8511642 -
Attachment is obsolete: true
Assignee | ||
Comment 7•10 years ago
|
||
Need a rebase for 1083745.
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8511908 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8511643 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8511845 -
Attachment is obsolete: true
Assignee | ||
Comment 11•10 years ago
|
||
Move some utility functions into head.js, then we can reuse them in part4.
Attachment #8519842 -
Attachment is obsolete: true
Assignee | ||
Comment 12•10 years ago
|
||
Attachment #8511893 -
Attachment is obsolete: true
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8519769 [details] [diff] [review] Part 1: Introduce head.js and rewrite test_icc_card_lock.js with Promise, v3 Review of attachment 8519769 [details] [diff] [review]: ----------------------------------------------------------------- This patch introduces the head.js which provides utility functions for icc, then we can write tests with promise. And the stk_helper.js [1] and icc_header.js [2] will be removed after all the tests are moved to promise in bug 1087968. This patch also separates tests for changing pin and getting retry count to two files. May I have your review, Hsinyi? Thank you. [1] http://dxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/stk_helper.js [2] http://dxr.mozilla.org/mozilla-central/source/dom/icc/tests/marionette/icc_header.js
Attachment #8519769 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Attachment #8519806 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Attachment #8519848 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Attachment #8519850 -
Flags: review?(htsai)
Comment 14•9 years ago
|
||
Comment on attachment 8519769 [details] [diff] [review] Part 1: Introduce head.js and rewrite test_icc_card_lock.js with Promise, v3 Review of attachment 8519769 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/icc/tests/marionette/head.js @@ +164,5 @@ > + > + Promise.resolve() > + .then(aTestCaseMain) > + .then(() => {}, () => { > + ok(false, 'promise rejects during test.'); Please also print out |error| in reject callback. nit: we can simply use |.catch|. ::: dom/icc/tests/marionette/test_icc_card_lock_change_pin.js @@ +38,5 @@ > + }) > + // Test PIN code changes fail. > + // The retry count should be decreased by 1. > + .then(() => testChangePin(icc, "1111", DEFAULT_PIN, "IncorrectPassword", > + retryCount -1)) nit" space between "-" and 1.
Attachment #8519769 -
Flags: review?(htsai) → review+
Updated•9 years ago
|
Attachment #8519806 -
Flags: review?(htsai) → review+
Updated•9 years ago
|
Attachment #8519848 -
Flags: review?(htsai) → review+
Comment 15•9 years ago
|
||
Comment on attachment 8519850 [details] [diff] [review] Part 4: Add marionette test for unlocking puk, v2 Review of attachment 8519850 [details] [diff] [review]: ----------------------------------------------------------------- Thank you very much for the tests :D
Attachment #8519850 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 16•9 years ago
|
||
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #14) > Comment on attachment 8519769 [details] [diff] [review] > Part 1: Introduce head.js and rewrite test_icc_card_lock.js with Promise, v3 > > Review of attachment 8519769 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/icc/tests/marionette/head.js > @@ +164,5 @@ > > + > > + Promise.resolve() > > + .then(aTestCaseMain) > > + .then(() => {}, () => { > > + ok(false, 'promise rejects during test.'); > > Please also print out |error| in reject callback. > > nit: we can simply use |.catch|. Okay, will do. Thank you. > > ::: dom/icc/tests/marionette/test_icc_card_lock_change_pin.js > @@ +38,5 @@ > > + }) > > + // Test PIN code changes fail. > > + // The retry count should be decreased by 1. > > + .then(() => testChangePin(icc, "1111", DEFAULT_PIN, "IncorrectPassword", > > + retryCount -1)) > > nit" space between "-" and 1. Will do.
Assignee | ||
Comment 17•9 years ago
|
||
Address review comment #14: - print out |error| and use |.catch()|. - space between "-" and 1.
Attachment #8519769 -
Attachment is obsolete: true
Attachment #8528744 -
Flags: review+
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8519850 [details] [diff] [review] Part 4: Add marionette test for unlocking puk, v2 Review of attachment 8519850 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/icc/tests/marionette/test_icc_card_lock_unlock_puk.js @@ +83,5 @@ > + retryCount = aResult.retryCount; > + ok(true, "puk retryCount is " + retryCount); > + }) > + > + // Test unlock PIN code fail. typo here, should be "PUK". :p
Assignee | ||
Comment 19•9 years ago
|
||
Address comment #18: - s/PIN/PUK/
Attachment #8519850 -
Attachment is obsolete: true
Assignee | ||
Comment 20•9 years ago
|
||
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=ed69ea52ca32
Assignee | ||
Comment 21•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/3d6c6dd443ae https://hg.mozilla.org/integration/b2g-inbound/rev/3392f55163d3 https://hg.mozilla.org/integration/b2g-inbound/rev/d638e47fe638 https://hg.mozilla.org/integration/b2g-inbound/rev/1ce89b6f8989
Comment 22•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d6c6dd443ae https://hg.mozilla.org/mozilla-central/rev/3392f55163d3 https://hg.mozilla.org/mozilla-central/rev/d638e47fe638 https://hg.mozilla.org/mozilla-central/rev/1ce89b6f8989
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S1 (5dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•