1084242 - Fix hint problems for: shared/js/fb/

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Sudheesh Singanamalla (:ShellHacker)]

Fix the jshint errors in shared/js/fb/

Comment 1

[Sudheesh Singanamalla (:ShellHacker)]

I have errors for strict violation in these files because of `this`, How should I go ahead with fixing these ?

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #1)
> I have errors for strict violation in these files because of `this`, How
> should I go ahead with fixing these ?

Can you upload a pull request and link me to the failing line number?

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

https://github.com/sudheesh001/gaia/blob/01b3991a19f1922f38834aadae80949449747cc9/shared/js/fb/fb_data_reader.js#L8-L9

https://github.com/sudheesh001/gaia/blob/01b3991a19f1922f38834aadae80949449747cc9/shared/js/fb/fb_reader_utils.js#L7-L8
https://github.com/sudheesh001/gaia/blob/01b3991a19f1922f38834aadae80949449747cc9/shared/js/fb/fb_reader_utils.js#L10-L11
https://github.com/sudheesh001/gaia/blob/01b3991a19f1922f38834aadae80949449747cc9/shared/js/fb/fb_reader_utils.js#L309-L310

shared/js/fb/fb_request.js: line 3, col 10, Possible strict violation.
shared/js/fb/fb_request.js: line 4, col 1, Possible strict violation.
shared/js/fb/fb_request.js: line 8, col 12, Possible strict violation.
shared/js/fb/fb_request.js: line 9, col 1, Possible strict violation.

the fb_request.js file hasn't been edited hence not committed.

Pull request : https://github.com/mozilla-b2g/gaia/pull/25293

Comment 4

[Kevin Grandon :kgrandon]

Like the other bug, I need to spend some time thinking about a proper pattern to use for fb_request.js. If you'd like, perhaps we can modify this PR to only lint the other two files for now, until we have a nice pattern to use.

Comment 5

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25293

I've fixed up most of the other problems present in these files on shared/js/fb

All the 3 files now only have one type of an error "Possible Strict Violation"

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8515415 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25293

Well this looks good, but we need to get rid of this error before we can land.

I wonder, would the jshint: worker option solve this for us? http://www.jshint.com/docs/options/#worker

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1084242_jshint_shared_fb > mozilla-b2g:master

Comment 8

[Kevin Grandon :kgrandon]

I'm attaching a new un-bitrotted patch based on your original patch here.  Going to see what the integration stuff does with this. Thank you for the initial work here, if it looks good we can finally land this.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8600413 [details] [review]
[gaia] KevinGrandon:bug_1084242_jshint_shared_fb > mozilla-b2g:master

Thanks for the initial work here Sudheesh! I've just rebased your work and applied some small fixes to make jshint happy. I think we should be good to go here now.

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/4f2982eecc48d23bb00ef7dbeb572e5949b9b471

Comment 11

[Sudheesh Singanamalla (:ShellHacker)]

Great !! :D