1084258 - Language pack compatibility should be bound to Gecko branch, else undefined entity errors possible

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

SeaMonkey 2.30 on Windows 8.1 64 bit

Upgrading from SeaMonkey 2.29.1 with the German language pack active to SeaMonkey 2.30 keeps the German language pack for SeaMonkey 2.29 active. This causes undefined entity error, e.g. when opening menu Help > Troubleshooting Information ("Hilfe" > "Informationen zur Fehlerbehebung") because it contains strings added in Gecko 33 (SeaMonkey 2.30).

Steps to reproduce:
1. Install SeaMonkey 2.29 from https://ftp.mozilla.org/pub/mozilla.org/seamonkey/releases/2.29/
2. Install German language pack from https://ftp.mozilla.org/pub/mozilla.org/seamonkey/releases/2.29/langpack/
3. Set general.useragent.locale to de
4. Restart SeaMonkey.
5. Open menu "Hilfe" > "Informationen zur Fehlerbehebung".

This is caused by the maxVersion 2.* in the compatibility information in install.rdf:

        <em:minVersion>2.30</em:minVersion>
        <em:maxVersion>2.*</em:maxVersion>

Comment 2

[Robert Kaiser]

It's definitely a bug that langpacks end up with that, they should end up with e.g. "2.30.*" in this case.

That said, if you have an online connection and that version of the langpack is up on AMO, I thought that we'd request the compat data from AMO where the correct data is set and then things should work fine.

Comment 3

[Ian Neal]

The bug that broke it is bug 940973. We either need to override this for SM, or special case the setting of it.

Comment 5

[Robert Kaiser]

Attachment: add a special case for SeaMonkey maxVersion

This is a patch that special-cases SeaMonkey to give it an appropriate maxVersion, as it uses a version scheme where the second number changes for every Gecko version but the first doesn't.

I have tested this with current SeaMonkey beta by enabling debugQA, which also uses this maxVersion definition (language repack is a bit hard, and pre-beta versions do not use this .* thing at all).

Mike, you reviewed bug 940973, which caused this issue, so I hope you are the peer with best knowledge of this code.

Comment 6

[Robert Kaiser]

Taking this bug for now, granted that my patch or something very near to it is acceptable.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8586967 [details] [diff] [review]
add a special case for SeaMonkey maxVersion

Review of attachment 8586967 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8618,5 @@
>  # 24.1.1 becomes 24.*
>  IS_ALPHA=`echo $MOZ_APP_VERSION | grep a`
>  if test -z "$IS_ALPHA"; then
>    changequote(,)
> +  if test "$MOZ_APP_NAME" = "seamonkey"; then

It would be better to test something like "$(basename $MOZ_BUILD_APP)" = "suite", that would make it work with rebrandings.

@@ +8619,5 @@
>  IS_ALPHA=`echo $MOZ_APP_VERSION | grep a`
>  if test -z "$IS_ALPHA"; then
>    changequote(,)
> +  if test "$MOZ_APP_NAME" = "seamonkey"; then
> +    MOZ_APP_MAXVERSION=`echo $MOZ_APP_VERSION | sed "s|\(^[0-9]*.[0-9]*\).*|\1|"`.*

you should escape the dot between the two numbers.

Comment 8

[Robert Kaiser]

Attachment: patch v2: special-case seamonkey maxVersion

Mike, here's a patch incorporating your comments, and it seems to still work in my testing.

Comment 9

[Robert Kaiser]

Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/7d3c573eab2e

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7d3c573eab2e

Comment 11

[Robert Kaiser]

Comment on attachment 8587116 [details] [diff] [review]
patch v2: special-case seamonkey maxVersion

tl;dr: This patch will only take actual effect once in beta and doesn't affect Firefox at all, it only adds a special case for SeaMonkey.

Approval Request Comment
[Feature/regressing bug #]: bug 940973
[User impact if declined]: no impact for Firefox in either direction; if we don't take this, official SeaMonkey langpacks continue to break the whole application after a SeaMonkey update is installed, and for uploading to AMO, langpacks need to be repacked to fix this.
[Describe test coverage new/current, TreeHerder]: Has passed tests fine on inbound, but this patch really only takes effect on beta/release. I did local SeaMonkey testing for beta.
[Risks and why]: There shouldn't be any risk for Firefox, as the new rule only gets invoked for SeaMonkey.
[String/UUID change made/needed]: -

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8587116 [details] [diff] [review]
patch v2: special-case seamonkey maxVersion

Taking as the risk should be minimal for Firefox (especially in the configure), early in the cycle and we want to help our Seamonkey friends.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4bdab5a3e2d8

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c5c12705b50