1084290 - (App-grouping) You should be able to drag an icon into a collapsed group

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

Currently it's not possible to drag an icon onto a collapsed group, but doing so should drop the icon in the collapsed group.

Comment 1

[Chris Lord [:cwiiis]]

Implemented: https://github.com/Cwiiis/gaia/tree/bug1084290-drag-item-to-collapsed-group

Just need to see about writing tests.

Comment 2

[Chris Lord [:cwiiis]]

I'm a bit stuck on this at the moment, as marionette appears to have a bug that all vertical movement after a handled long-press on the home-screen still causes scrolling...

Possibly I can work around this by collapsing lots of groups, but that's a temporary work-around at best. This needs to be fixed (it affected some other tests I wrote too, but thankfully not so much as to cause them to fail/not test what they're meant to test).

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Allow dragging an item into a collapsed group

I think review from either of you would be fine, but I think both of you should see it.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8507997 [details] [review]
Allow dragging an item into a collapsed group

Looks good to me.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8507997 [details] [review]
Allow dragging an item into a collapsed group

LGTM Chris as well, good job!

Comment 6

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/9f343453de058582e84265231d00f11b9e2649d8

Comment 8

[Maria Sandberg [:mushi]]

Could we consider changing the behavior to expanding the group when an icon is dragged in to it? Something like this:

Suggested behavior:
1. Long press app to enter edit mode. 
2. Drag app from expanded group and hover over collapsed group.
3. Collapsed group expands under the hovering app and the user can place the app icon within the new expanded group. 
4. User drops icon to confirm placement. 
5. Group stays expanded (not sure about this one).

If it's not doable that's fine, I know Chris mentioned there may be some animation issues here but it would be worth trying.

Comment 9

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed in Flame 3.0

The user can properly place Icons into a collapsed group during edit mode on the homescreen.

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0