1084387 - "show in product picker" option for product

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We have products set up on Input that we want public (aka, they show up on the public dashboard), but that we probably don't want to show up in the product picker. For example, we probably don't want Loop to show up in the product picker.

This bug covers:

1. Adding another field to the feedback_product table for this. It should default to False.

2. Fixing the product picker form to skip products that are not public and products that shouldn't be shown in the picker.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1--it needs to get done asap.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think this is like a day of work. Making it 2 points.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/369

This ended up taking an hour, so reducing the points to 1.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Also, I changed the scope a bit. I fixed the product picker to only show products that have on_picker=True. I think we should leave out on_dashboard from the filter. They should be two separate flags.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

We need to add two more action items here:

3. Add field to Product admin

4. Add field to Product management templates

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master:

https://github.com/mozilla/fjord/commit/e8a9cc73c0e157af5b144b7b397b3e9586fa5488
https://github.com/mozilla/fjord/commit/2af4fca850e906afa48226004ac8286c1024d4d2

Pushed to prod just now.