Closed Bug 1084430 Opened 9 years ago Closed 7 years ago

Objects with properties named "<return>" or "<exception>" get styled like actual returns/exceptions do in the debugger

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: fitzgen, Assigned: tromey)

References

(Blocks 1 open bug)

Details

(Whiteboard: [polish-backlog])

Attachments

(1 file, 2 obsolete files)

fix styling of <return> and <exception> in variable view
19.22 KB, patch
tromey
: review+
Details | Diff | Splinter Review 
STR:

  In the console, or in some variable that is in scope when the
  debugger is paused:

  > obj = { "<return>": 5 }

ER:

  The <return> key is black, like regular property keys (or like
  it is if you have a "<foo>" property key.

AR:

  It is highlighted the color we use to distinguish returns and
  exceptions from properties and variables in the debugger.
Whiteboard: [polish-backlog]
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Now with updated doc comments.
Attachment #8689051 - Attachment is obsolete: true
Attachment #8689065 - Flags: review?(vporof)
Attachment #8689065 - Flags: review?(vporof) → review+
Rebased, added r=.
Attachment #8689065 - Attachment is obsolete: true
Attachment #8689563 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c6d9dafc91a1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.