Closed
Bug 1084527
Opened 10 years ago
Closed 10 years ago
Reference to undefined property child.qName
Categories
(Chat Core :: XMPP, defect)
Chat Core
XMPP
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
1.60 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
resource:///modules/xmpp-xml.jsm, line 216: ReferenceError: reference to undefined property child.qName There are two possible approaches to this 1) check ("qname" in child) 2) throw if an XML node is created without a valid qName Not sure off-hand which is correct.
Assignee | ||
Comment 2•10 years ago
|
||
This happens for text nodes, which have no qName.
Comment 3•10 years ago
|
||
Comment on attachment 8507501 [details] [diff] [review] qname.diff Review of attachment 8507501 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Is anything here worth adding comments to?
Attachment #8507501 -
Flags: review?(clokep) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/ce8c62cb7b7c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•