1084527 - Reference to undefined property child.qName

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

resource:///modules/xmpp-xml.jsm, line 216: ReferenceError: reference to undefined property child.qName

There are two possible approaches to this
1) check ("qname" in child)
2) throw if an XML node is created without a valid qName

Not sure off-hand which is correct.

Comment 2

[aleth [:aleth]]

Attachment: qname.diff

This happens for text nodes, which have no qName.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8507501 [details] [diff] [review]
qname.diff

Review of attachment 8507501 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Is anything here worth adding comments to?

Comment 4

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/ce8c62cb7b7c