Closed
Bug 1084557
Opened 10 years ago
Closed 10 years ago
Stumbler: remove condition to only build in Nightly
Categories
(Android Background Services Graveyard :: Geolocation, defect)
Tracking
(firefox35 fixed, firefox36 fixed, fennec35+)
RESOLVED
FIXED
Firefox 36
People
(Reporter: garvan, Assigned: garvan)
Details
Attachments
(1 file)
|
986 bytes,
patch
|
rnewman
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
AaronMT caught this one: http://mxr.mozilla.org/mozilla-central/source/mobile/android/confvars.sh#90 if test "$NIGHTLY_BUILD"; then 91 MOZ_ANDROID_MLS_STUMBLER=1 92 else 93 MOZ_ANDROID_MLS_STUMBLER= 94 fi Needs to be on for all build variants.
Removed the nightly-only check in android/confvars.sh for stumbler.
Attachment #8507130 -
Flags: review?(rnewman)
|
||
Comment 2•10 years ago
|
||
tracking-fennec: ? -> 35, because there are permissions exposed without a feature
tracking-fennec: --- → ?
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8507130 [details] [diff] [review] change to android/confvars.sh Review of attachment 8507130 [details] [diff] [review]: ----------------------------------------------------------------- Technically fine.
Attachment #8507130 -
Flags: review?(rnewman) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Summary: Stumbler: remove condition to only build in nightly → Stumbler: remove condition to only build in Nightly
Thanks Richard. Try is green: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d89df190914a
Keywords: checkin-needed
Comment on attachment 8507130 [details] [diff] [review] change to android/confvars.sh Approval Request Comment [Feature/regressing bug #]: Fennec stumbler meta-bug bug 1038843. [User impact if declined]: The intention is to land this feature for 35, it was ifdef'd to nightly only, and the change was missed in the rollover to aurora [Describe test coverage new/current, TBPL]: none [Risks and why]: No geolocation stumbling feature in Fennec 35 [String/UUID change made/needed]: None
Attachment #8507130 -
Flags: approval-mozilla-aurora?
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bbad7204385f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bbad7204385f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
|
||
Updated•10 years ago
|
Attachment #8507130 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 8•10 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: [Suggested wording]: [Links (documentation, blog post, etc)]:
The release note request is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1054520#c11
|
||
Updated•10 years ago
|
tracking-fennec: ? → 35+
You need to log in
before you can comment on or make changes to this bug.
Description
•