Stumbler: remove condition to only build in Nightly

RESOLVED FIXED in Firefox 35

Status

Android Background Services
Geolocation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: garvan, Assigned: garvan)

Tracking

Firefox 35
Firefox 36
All
Android
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, fennec35+)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
AaronMT caught this one:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/confvars.sh#90
if test "$NIGHTLY_BUILD"; then
91   MOZ_ANDROID_MLS_STUMBLER=1
92 else
93   MOZ_ANDROID_MLS_STUMBLER=
94 fi

Needs to be on for all build variants.
(Assignee)

Comment 1

4 years ago
Created attachment 8507130 [details] [diff] [review]
change to  android/confvars.sh

Removed the nightly-only check in android/confvars.sh for stumbler.
Attachment #8507130 - Flags: review?(rnewman)
tracking-fennec: ? -> 35, because there are permissions exposed without a feature
tracking-fennec: --- → ?
Comment on attachment 8507130 [details] [diff] [review]
change to  android/confvars.sh

Review of attachment 8507130 [details] [diff] [review]:
-----------------------------------------------------------------

Technically fine.
Attachment #8507130 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Summary: Stumbler: remove condition to only build in nightly → Stumbler: remove condition to only build in Nightly
(Assignee)

Comment 4

4 years ago
Thanks Richard. 

Try is green:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d89df190914a
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
Comment on attachment 8507130 [details] [diff] [review]
change to  android/confvars.sh

Approval Request Comment
[Feature/regressing bug #]: Fennec stumbler meta-bug bug 1038843.
[User impact if declined]: The intention is to land this feature for 35, it was ifdef'd to nightly only, and the change was missed in the rollover to aurora
[Describe test coverage new/current, TBPL]: none
[Risks and why]: No geolocation stumbling feature in Fennec 35
[String/UUID change made/needed]: None
Attachment #8507130 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/bbad7204385f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bbad7204385f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Attachment #8507130 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:
status-firefox35: --- → affected
status-firefox36: --- → fixed
relnote-firefox: --- → ?
(Assignee)

Comment 9

4 years ago
The release note request is here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1054520#c11
tracking-fennec: ? → 35+
Flags: qe-verify-
noted this linked to bug 1054520
relnote-firefox: ? → ---
You need to log in before you can comment on or make changes to this bug.