1084558 - browser_httphash6.js crashes in e10s mode

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Somehow we end up passing a window CPOW to Services.ww.openWindow.

0 Installer_checkAllDownloaded() ["file:///Users/dave/mozilla/build/nightly-debug/dist/NightlyDebug.app/Contents/Resources/components/amWebInstallListener.js":186]
    this = [object Object]
1 Installer_onDownloadEnded(aInstall = [object Object]) ["file:///Users/dave/mozilla/build/nightly-debug/dist/NightlyDebug.app/Contents/Resources/components/amWebInstallListener.js":240]
    this = [object Object]
2 AMI_callInstallListeners(aMethod = "onDownloadEnded", aExtraListeners = [object Object],[object Object], aArgs = [object Object]) ["resource://gre/modules/AddonManager.jsm":1493]
    this = [object Object]
3 AMP_callInstallListeners(aArgs = onDownloadEnded,[object Object],[object Object],[object Object], [object Object],[object Object], [object Object]) ["resource://gre/modules/AddonManager.jsm":2443]
    this = [object Object]
4 downloadCompleted_getVisibleAddonForID(aAddon = null) ["resource://gre/modules/addons/XPIProvider.jsm":5621]
5 anonymous(aArgs = ) ["resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js":146]
6 getRepositoryAddon(aAddon = null, aCallback = [function]) ["resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js":127]
    this = [object Object]
7 anonymous(addonDB = [object Map]) ["resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js":1071]
    this = [object Object]
8 anonymous() ["resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js":865]
    this = [object Object]
9 anonymous() ["resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js":744]
    this = [object Object]

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Well there is a quick fix here but the problem stems from the add-on manager using a number of APIs that in non-e10s mode take DOM windows and in e10s mode take browser elements. This causes some confusion so I decided to unify to use browser elements everywhere.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8515253 [details] [diff] [review]
patch

Review of attachment 8515253 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/amWebInstallListener.js
@@ +181,5 @@
> +          // These parts may throw if the browser has already been closed.
> +          if (this.browser.contentWindow)
> +            parentWindow = this.browser.contentWindow;
> +          let tabbrowser = this.browser.getTabBrowser();
> +          tabbrowser.selectedTab = tabbrowser.getTabForBrowser(this.browser);

:(

I wish we'd invest in building proper implementation-agnostic APIs, instead of continually adding more technical debt because of e10s.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 2

(In reply to Blair McBride [:Unfocused] from comment #2)
> Comment on attachment 8515253 [details] [diff] [review]
> patch
> 
> Review of attachment 8515253 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/mozapps/extensions/amWebInstallListener.js
> @@ +181,5 @@
> > +          // These parts may throw if the browser has already been closed.
> > +          if (this.browser.contentWindow)
> > +            parentWindow = this.browser.contentWindow;
> > +          let tabbrowser = this.browser.getTabBrowser();
> > +          tabbrowser.selectedTab = tabbrowser.getTabForBrowser(this.browser);
> 
> :(
> 
> I wish we'd invest in building proper implementation-agnostic APIs, instead
> of continually adding more technical debt because of e10s.

Good news, we already have and I just didn't know about it.

Comment 4

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/ea6f00d19dca

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea6f00d19dca