Enable xpinstall tests in e10s

RESOLVED FIXED in mozilla36

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(e10s+)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Currently they are completely disabled but many of them appear to work and there are probably common problems for the ones that don't. Enable the ones that work and either fix or file specific bugs on the ones that don't.
Flags: qe-verify-
Flags: firefox-backlog+

Updated

4 years ago
Points: --- → 2
(Assignee)

Updated

4 years ago
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Iteration: --- → 36.1
(Assignee)

Updated

4 years ago
Depends on: 1082764
(Assignee)

Updated

4 years ago
Depends on: 1083269
(Assignee)

Updated

4 years ago
Depends on: 1084558
(Assignee)

Comment 1

4 years ago
Created attachment 8507175 [details] [diff] [review]
patch

So this is a good first step. Mostly simple fixes that gets the majority of the tests working. In some cases we were relying on executeSoon to allow callbacks to be called so now we wait for specific events from content. All other test failures look warrant their own bugs.
Attachment #8507175 - Flags: review?(bmcbride)
Comment on attachment 8507175 [details] [diff] [review]
patch

Review of attachment 8507175 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/xpinstall/browser_enabled.js
@@ +6,5 @@
>    gBrowser.selectedTab = gBrowser.addTab();
>    gBrowser.selectedBrowser.addEventListener("load", function() {
>      gBrowser.selectedBrowser.removeEventListener("load", arguments.callee, true);
> +    gBrowser.contentWindow.addEventListener("PageLoaded", function() {
> +      gBrowser.contentWindow.removeEventListener("PageLoaded", arguments.callee, false);

We shouldn't be adding new usage of arguments.callee - name the listener instead. Few other cases of this in the patch to fix up.
Attachment #8507175 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/de20db682279
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Assignee)

Updated

4 years ago
Depends on: 1082871
(Assignee)

Updated

4 years ago
Depends on: 1095128
(Assignee)

Updated

4 years ago
No longer depends on: 1095128
You need to log in before you can comment on or make changes to this bug.