1084590 - Update string and image on "first run" view of Search Activity for V1

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: XXHDPI - Mobile - First run 6.png

As per requests of Joanne and Karen, made some changes around the messaging of the "First run" view in the Search Activity.

There were concerns of calling it "Firefox Search" for release so this address that. Also, updating the fox graphic to the Firefox 1-tone logo for branding concerns.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: 1tonefox.zip

Attaching 1 tone fox image

Comment 2

[:Margaret Leibovic]

I can take this.

However, this is going to require uplifting strings to Aurora now. It's still early in the cycle, so hopefully that's okay.

Comment 3

[:Margaret Leibovic]

How strongly do you feel about changing message below the header? "Quickly find anything that you're looking for" sounds weird to me, probably because it ends in a preposition. Can we just stick with "Quickly search for anything you want"?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #3)
> How strongly do you feel about changing message below the header? "Quickly
> find anything that you're looking for" sounds weird to me, probably because
> it ends in a preposition. Can we just stick with "Quickly search for
> anything you want"?

I'm fine with that. I just thought it weird to have "search" in 3 places all on the same view.

Thanks Margaret!

Comment 5

[:Margaret Leibovic]

Do we want to change the name of the launcher icon as well? Or are we okay with keeping that as "Firefox Search"?

Comment 6

[:Margaret Leibovic]

Attachment: Update message and icon in empty view of search activity

Comment 7

[Karen Rudnitski [:kar]]

Joanne - we use the name of the channel in front of 'search' when naming the icon. So it's 'Nightly Search', 'Aurora Search', 'Beta Search' then it would be 'Firefox Search'.

I presume it should be adequately explained as such? I hope you don't foresee any issue with any of our possible partners?

Thanks!

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8507247 [details] [diff] [review]
Update message and icon in empty view of search activity

Review of attachment 8507247 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/fda425362024

We can file a separate bug for the launch icon naming if we decide that needs to change as well.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fda425362024

Comment 11

[:Margaret Leibovic]

Comment on attachment 8507247 [details] [diff] [review]
Update message and icon in empty view of search activity

Approval Request Comment
[Feature/regressing bug #]: search activity v1
[User impact if declined]: branding on first run feels wrong
[Describe test coverage new/current, TBPL]: just landed on m-c, no automated tests
[Risks and why]: low-risk, string/icon swap 
[String/UUID change made/needed]: one string change ('&brandShortName; Search' -> 'Start searching')

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to :Margaret Leibovic from comment #11)

> [String/UUID change made/needed]: one string change ('&brandShortName;
> Search' -> 'Start searching')

If it's not already, can the new string be something that's already localized? That's one way to get around string freeze for a one line change. Otherwise we'll have to ping l10n and make a case for late l10n here.

Comment 13

[:Margaret Leibovic]

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #12)
> (In reply to :Margaret Leibovic from comment #11)
> 
> > [String/UUID change made/needed]: one string change ('&brandShortName;
> > Search' -> 'Start searching')
> 
> If it's not already, can the new string be something that's already
> localized? That's one way to get around string freeze for a one line change.
> Otherwise we'll have to ping l10n and make a case for late l10n here.

I don't think there's another existing string we can use. I'll defer to Karen for whether or not we want to push to uplift this.

Alternately, we could hide that header altogether, and just have the "Quickly search for anything you want" text appear.

Comment 14

[Karen Rudnitski [:kar]]

We have to do something, although we could take Margaret's alternative and make the change for the more succinct wording for the next release.

Comment 15

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Karen Rudnitski [:kar] from comment #14)
> We have to do something, although we could take Margaret's alternative and
> make the change for the more succinct wording for the next release.

Works for me.

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Great - can we get a new aurora approval nominated patch with that option, Margaret?

Comment 17

[:Margaret Leibovic]

Attachment: Aurora patch

Updated to have no string changes.

Approval Request Comment
[Feature/regressing bug #]: search activity v1
[User impact if declined]: branding on first run feels wrong
[Describe test coverage new/current, TBPL]: just landed on m-c, no automated tests
[Risks and why]: low-risk, string/icon swap 
[String/UUID change made/needed]: none

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3a36eb03ce30

Comment 19

[:Margaret Leibovic]

Removing late-l10n, since we didn't uplift the string.

Comment 20

[Flaviu Cos]

Verified as fixed in builds:
- 36.0a1 2014-11-17;
- 35.0a2 2014-11-17;
Device: Asus Transformer Tab (Android 4.0.3).