1084633 - Sender name shown for sessionstart messages as well as messages without a sender name in search results.

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Comment 1

[aleth [:aleth]]

Comment on attachment 8507217 [details] [diff] [review]
Patch

Review of attachment 8507217 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: mail/components/im/modules/index_im.js
@@ +445,5 @@
>      if (!aLogConv)
>        return Gloda.kWorkDone;
>  
>      let content = aLogConv.getMessages()
> +                          .filter(m => !m.noLog)

Please add a comment here to avoid future confusion as to why Log.getMessages can return noLog messages before checking it in.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Added the requested comment, carrying forward the r+.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/dfe17237503f

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bustage fix

Remove extra parenthesis

Comment 5

[aleth [:aleth]]

Comment on attachment 8516158 [details] [diff] [review]
Bustage fix

Review of attachment 8516158 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Please land this asap, a=bustage-fix.

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/comm-central/rev/e52b7e18a9b5